Ticket #863 (assigned defect)

Opened 4 years ago

Last modified 3 years ago

Screen rotation on lid close - Dell Latitude D380

Reported by: martin.langhoff Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: Unspecified by Release Team
Component: sugar Version: Unspecified
Severity: Unspecified Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

My Latitude D380 records (according to showkey)

227 press
227 release
227 press
227 release

on every lid close / lid open cycle. Sugar has this hardcoded to screen rotate, probably correct on the XO.

Attachments

foo.patch Download (1.7 KB) - added by biertie 4 years ago.

Change History

Changed 4 years ago by biertie

  Changed 4 years ago by biertie

a patch for this problem Bernie and I came up with..

follow-up: ↓ 3   Changed 4 years ago by tomeu

What do you think about moving the rotation key handling to an extension? That way we can keep the hacks out from the shell, which is way safer (because failures in extensions are not propagated to the main loop) and is also nicer from a code organization point of view.

Btw, please see  http://wiki.sugarlabs.org/go/Development_Team/CodeReview

in reply to: ↑ 2 ; follow-up: ↓ 4   Changed 4 years ago by bernie

Replying to tomeu:

What do you think about moving the rotation key handling to an extension? That way we can keep the hacks out from the shell, which is way safer (because failures in extensions are not propagated to the main loop) and is also nicer from a code organization point of view.

Sounds like a good idea, but I lack the expertise to design this solution properly. Are you thinking about an XO specific extension to handle all these little things?

Btw, please see  http://wiki.sugarlabs.org/go/Development_Team/CodeReview

Thanks

in reply to: ↑ 3   Changed 4 years ago by tomeu

Replying to bernie:

Replying to tomeu:

What do you think about moving the rotation key handling to an extension? That way we can keep the hacks out from the shell, which is way safer (because failures in extensions are not propagated to the main loop) and is also nicer from a code organization point of view.


Sounds like a good idea, but I lack the expertise to design this solution properly.

Don't be so lazy! This is really easy and fun stuff. As an example, this extension will take a screenshot when the user presses the Print key:

 http://git.sugarlabs.org/projects/sugar/repos/mainline/blobs/master/extensions/globalkey/screenshot.py

Are you thinking about an XO specific extension to handle all these little things?

Yeah, one for all the special keys on the XO.

Btw, please see  http://wiki.sugarlabs.org/go/Development_Team/CodeReview


Thanks

Btw, if you don't put r? in the keywords field, the ticket won't be in the review queue and can get lost for several months.

  Changed 3 years ago by sdz

  • milestone soas_fossvt deleted

Milestone soas_fossvt deleted

  Changed 3 years ago by sascha_silbe

  • owner changed from tomeu to mchua sdz
  • distribution changed from SoaS to Unspecified
  • component changed from sugar to SoaS

Bulk change distribution=SoaS -> component=SoaS

  Changed 3 years ago by sdz

  • owner changed from mchua sdz to tomeu
  • status changed from new to assigned
  • component changed from SoaS to sugar
  • milestone set to Unspecified by Release Team

Assigning back to Sugar.

Note: See TracTickets for help on using tickets.