Ticket #757 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

telepathy_room_handle unused and unusable

Reported by: gdesmott Owned by: erikos
Priority: Unspecified by Maintainer Milestone: Unspecified by Release Team
Component: sugar-toolkit Version: Unspecified
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

While porting Read to the new tube API, I discovered that Activity._telepathy_room_handle was:
a) never set so was always None
b) potentially usefull for activities (I use it for the port).

The following branch fix these 2 issues by actually setting the value of the room handle and making it public. I think this change is safe, I grepped sugar-jhbuild source and didn't find any code using it (which make sense as it was unusable).

 http://git.sugarlabs.org/projects/sugar-toolkit/repos/cassids-sugar-toolkit/trees/room-handle

Attachments

room-handle.patch Download (1.0 KB) - added by gdesmott 4 years ago.
src/sugar/presence/activity.py | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

Change History

Changed 4 years ago by gdesmott

  • keywords r? added

Changed 4 years ago by gdesmott

src/sugar/presence/activity.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

Changed 4 years ago by erikos

  • keywords r+ added; r? removed

Looks good to me, thanks.

Changed 4 years ago by gdesmott

Seems src/sugar/presence/activity.py has been deleted in master. I can't merge my branch.

Changed 4 years ago by tomeu

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.