"Playwave" example not working: directory not found?

[sascha_silbe]

The "Playwave" example isn't working:

Traceback (most recent call last):

File "/home/sugar/.sugar/default/org.laptop.Pippy/tmp/pippy_app.py", line 5, in <module>

pippy.sound.playWave(sound='didjeridu', loop=True, duration=5)

File "/home/sugar/sugar-jhbuild/install/share/sugar/activities/Pippy.activity/library/pippy/sound.py", line 157, in playWave

fullname = finddir() + str(sound)

TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

[jpichon]

Display error message when sound is not found

[jpichon]

This is happening because PlayWave relies on TamTamEdit to provide the sound, which isn't always installed by default.

The Getsound example works around this by providing a helpful error message when finddir() returns None, so I'm attaching a patch to do the same for Playwave. Let me know if there would be a better way to deal with this.

[sascha_silbe]

I get the same error even after installing TamTam Edit. TamTam Edit itself doesn't play any sound, but that's a different bug.

[jpichon]

Thank you for the feedback. I was so keen on removing the stack trace and displaying an error message that I didn't properly check the validity of the message itself, sorry! It looks like the directory paths for TamTamEdit are hardcoded incorrectly in sound.py. Installing TamTamEdit doesn't work for the "Getsound" example either, I'm looking into it at the same time.

Is there a recommended way to access activity directories from Sugar? I've had some success with adding the following to finddir() in sound.py so far, though I still need to test it further and on different configurations:

    tamtam_dir = "TamTamEdit.activity/common/Resources/Sounds/"
    if "SUGAR_PATH" in os.environ:
        dirs.append(os.environ["SUGAR_PATH"] + "/activities/" + tamtam_dir)
    dirs.append(os.path.expanduser("~") + "/Activities/" + tamtam_dir)

[jpichon]

Here's a second patch that complements the first one and works for the "Getsoundlist" example as well. With the patch, they should both show the correct output if TamTamEdit is installed, and display an error message if it isn't.

[RafaelOrtiz]

This should be fixed in v40 of pippy.

[RafaelOrtiz]

confirmed as fixed.