Ticket #614 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

fail gracefully if LANG isn't set

Reported by: sascha_silbe Owned by: sascha_silbe
Priority: Low Milestone: 0.86
Component: sugar Version: Git as of bugdate
Severity: Minor Keywords: r+
Cc: tomeu Distribution/OS: Unspecified
Bug Status: Assigned

Description

Normally, LANG will be set by the login scripts. But if it isn't set, several parts of Sugar currently fail (tracebacks).
Since Sugar provides its own language chooser anyway, it makes sense to handle this more gracefully and set up locale variables (including LANG) accordingly early on startup. Another option would be to fix all occurences of direct uses of LANG inside Glucose to use the Control Panel settings instead.

Attachments

0001-set-default-language-614.patch Download (0.6 KB) - added by sascha_silbe 3 years ago.
set default language

Change History

  Changed 4 years ago by tomeu

  • milestone changed from Unspecified by Release Team to 0.86

  Changed 4 years ago by homunq

  • keywords sugar-love added

Changed 3 years ago by sascha_silbe

set default language

follow-up: ↓ 4   Changed 3 years ago by sascha_silbe

  • cc tomeu added
  • keywords r? added; sugar-love removed
  • status changed from new to accepted
  • owner changed from tomeu to sascha_silbe
  • status_field changed from Unconfirmed to Assigned

The attached patch sets the default language (to en_US.utf8) in sugar (shell script) prior to sourcing ~/.i18n.

in reply to: ↑ 3   Changed 3 years ago by tomeu

  • keywords r+ added; r? removed

Replying to sascha_silbe:

The attached patch sets the default language (to en_US.utf8) in sugar (shell script) prior to sourcing ~/.i18n.

Excellent, thanks!

  Changed 3 years ago by sascha_silbe

  • status changed from accepted to closed
  • resolution set to fixed

Pushed as  be156e18869ef888ade1a6d2268e49ff97742ddf, thanks!

Note: See TracTickets for help on using tickets.