Object Chooser of an activity gets over other activities

[manuq]

TestCase

• open imageviewer from scratch
• click the + button in the center of the canvas
• Switch to other activities

The Object Chooser should be tied to the activity that opens it, as a dialog window.

This traceback appears in the log:

Traceback (most recent call last):
  File "/home/manuq/sugar-build/install/lib/python2.7/site-packages/jarabe/journal/objectchooser.py", line 103, 
    self.set_transient_for(parent)
  File "/usr/lib64/python2.7/site-packages/gi/types.py", line 47, in function
    return info.invoke(*args, **kwargs)
TypeError: argument parent: Expected Gtk.Window, but got gi.repository.GdkX11.X11Window

[manuq]

The consequence of set_transient_for() failing with a TypeError is that the Object Chooser of an activity is displayed over other activities and also over the Journal.

It fails because the Gtk.Window is passed from toolkit to the shell through DBUS as an integer, the XID of the X11Window (GdkWindow). It is sent in toolkit's ObjectChooser and catched in shell's JournalActivityDBusService . So at the other side we have a GdkWindow.

So I've found that calling the method with the same name in the Gdk.Window fixes the issue. There is no error in the log, and the Object Chooser acts as a dialog, attached to the activity Window.
​http://developer.gnome.org/gdk/stable/gdk-Windows.html#gdk-window-set-transient-for

Patch attached.

[manuq]

Patch

[erikos]

ObjectChooser: make ObjectChooser transient for the parent window

[erikos]

The patch is good, but the description was not fully correct, imho. I rewrote it and attached a new patch.

Please push it to master and cherry-pick to sucrose-0.98 if you agree.

[erikos]

Replying to Rach4d:

Helping with keeping the bug database up to date is appreciated but please do not change severity unless you know what you are doing.

[manuq]

Thanks for the input, your description is the right one. Pushed and cherry-picked as f6ba32ce .

[dnarvaez]

Milestone 1.0 deleted