Opened 11 years ago
Last modified 9 years ago
#4397 new defect
Fix ViewSource layout
Reported by: | manuq | Owned by: | erikos |
---|---|---|---|
Priority: | Normal | Milestone: | Unspecified |
Component: | Sugar | Version: | Git as of bugdate |
Severity: | Minor | Keywords: | patch |
Cc: | erikos | Distribution/OS: | Unspecified |
Bug Status: | New |
Description (last modified by SAMdroid)
- Fix buttons alignment, they have bad spacing, should be left aligned.
- Palettes in radio buttons need to be ported
Attachments (10)
Change History (24)
Changed 11 years ago by manuq
comment:1 Changed 11 years ago by manuq
- Description modified (diff)
Changed 11 years ago by manuq
comment:2 Changed 11 years ago by manuq
- Description modified (diff)
comment:3 Changed 11 years ago by manuq
- Cc erikos added
- Keywords r? added
comment:4 Changed 11 years ago by manuq
Pushed remove resize grip as f095dc01 .
comment:5 follow-ups: ↓ 6 ↓ 7 Changed 11 years ago by erikos
I presume you add the 'gear icon' to make the Dialog more distinguishable. There should be a tooltip for that icon then as well. It would be better to factor that out in a separate patch as it is not a bug fix.
One thing I encountered, (with and without your patches), is that the selected feedback of the most left icon (activity icon) is bigger than the other ones. Would be nice to fix that as well.
comment:6 in reply to: ↑ 5 Changed 11 years ago by erikos
Replying to erikos:
One thing I encountered, (with and without your patches), is that the selected feedback of the most left icon (activity icon) is bigger than the other ones. Would be nice to fix that as well.
Actually, we have the same issue with the zoom levels in the Frame. When the neighborhood icon is selected the 'selected feedback' is bigger than the one of the other icons.
Changed 11 years ago by manuq
Changed 11 years ago by manuq
Changed 11 years ago by manuq
Changed 11 years ago by manuq
comment:7 in reply to: ↑ 5 ; follow-up: ↓ 8 Changed 11 years ago by manuq
Replying to erikos:
I presume you add the 'gear icon' to make the Dialog more distinguishable.
Yes, exactly, it is to identify the view.
There should be a tooltip for that icon then as well. It would be better to factor that out in a separate patch as it is not a bug fix.
Excellent. I reworked the patches and separated the gear in the last one.
One thing I encountered, (with and without your patches), is that the selected feedback of the most left icon (activity icon) is bigger than the other ones. Would be nice to fix that as well.
Yes, saw it too. I still don't know why is that, I'll give another look.
comment:8 in reply to: ↑ 7 Changed 11 years ago by erikos
Replying to manuq:
Replying to erikos:
One thing I encountered, (with and without your patches), is that the selected feedback of the most left icon (activity icon) is bigger than the other ones. Would be nice to fix that as well.
Yes, saw it too. I still don't know why is that, I'll give another look.
Actually, I narrowed that down to: open the view source dialog. The most left icon will have a bigger selected feedback grey. Now select a file in the view source dialog. The bigger feedback grey will be gone. It has something to do with focus it looks like.
comment:9 Changed 11 years ago by dnarvaez
- Component changed from untriaged to sugar
- Owner set to erikos
Temptatively assigning to sugar.
comment:10 Changed 10 years ago by dnarvaez
Manuel, did this land? Otherwise should we try to land it now?
comment:11 Changed 10 years ago by mystery828
- Bug Status changed from Unconfirmed to New
- Priority changed from Unspecified by Maintainer to Normal
comment:12 Changed 9 years ago by SAMdroid
- Description modified (diff)
- Severity changed from Unspecified to Minor
- Version changed from Unspecified to Git as of bugdate
Some of these are currently fixed and others are separate bugs.
The overflow toolbar is also in #4755 so I think we can let that be a separate ticket
comment:13 Changed 9 years ago by godiard
One issue I think is not solved yet, is the distance between the buttons in the toolbar.
comment:14 Changed 9 years ago by godiard
- Keywords patch added; r? removed
Image that shows some of the bugs