Touch: Get out of activity fullscreen mode

[erikos]

Example:

• open Browse

• go to full-mode

---> [-><-] button goes away after a timeout

• move the cursor

---> [-><-] button appears again and disappear after a timeout

• click on the canvas

---> no [-><-] button appears

• click on the top-top (the toolbar with the tabs)

---> [-><-] button appears

Tapping anywhere should bring back the button.

[erikos]

Read looks to behave quite well in this case.

[erikos]

Imageviewer does work as well. So looks like we should fix Browse only for now.

[humitos]

Maybe the code used in this patch can be modularized on the sugar3.graphics.window.Window class so it's not repeated

[manuq]

Terminal behaves well as well, so pushing humitos patch for Browse.

Thanks humitos, I just inverted the checks in the if conditional, first check if the activity is in fullscreen mode, so the callback returns right away if not.

Pushed c9975a7c .

[erikos]

I am not happy with the Browse patch:

• I think we should add that to the toolkit so it is available to all the activities, we should not only track mouse events there but as well show the unfullscreen button on button presses and touch taps, button presses were not considered before as they often get along with a mouse movement - it is rare that you do a click without a touch movement, but they should be considered to complete the picture.

• if you have to do things like "self._Windowunfullscreen_button_timeout_cb" often something is wrong with the approach, please check as well #1434 if there is not a better solution

Toolkit patch attached. Tested with Browse, Read and Imageviewer.

[erikos]

While checking, I think this code can go away in Read:

diff --git a/readactivity.py b/readactivity.py
index eaedf81..5ff413a 100644
--- a/readactivity.py
+++ b/readactivity.py
@@ -340,12 +340,6 @@ class ReadActivity(activity.Activity):
         #else:
         #    self._load_document('file:///home/smcv/tmp/test.pdf')
 
-    def fullscreen(self):
-        activity.Activity.fullscreen(self)
-
-    def unfullscreen(self):
-        activity.Activity.unfullscreen(self)
-
     def _create_back_button(self):
         back = ToolButton('go-previous-paired')
         back.set_tooltip(_('Back'))

[erikos]

Window: show unfullscreen button on button and touch events

[erikos]

Acked by Manuel: ​http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/20ef297526933144b981ec81245829acc016c1d5

[godiard]

Replying to erikos:

You are right, removed. (Before Read used the topbar in fullscreen mode, but is not used anymore)

While checking, I think this code can go away in Read:

diff --git a/readactivity.py b/readactivity.py
index eaedf81..5ff413a 100644
--- a/readactivity.py
+++ b/readactivity.py
@@ -340,12 +340,6 @@ class ReadActivity(activity.Activity):
         #else:
         #    self._load_document('file:///home/smcv/tmp/test.pdf')
 
-    def fullscreen(self):
-        activity.Activity.fullscreen(self)
-
-    def unfullscreen(self):
-        activity.Activity.unfullscreen(self)
-
     def _create_back_button(self):
         back = ToolButton('go-previous-paired')
         back.set_tooltip(_('Back'))

[greenfeld]

Touching the touchscreen or moving the mouse cursor causes the fullscreen exiting icon to appear for a few seconds in Browse-145/OLPC 13.1.0 os9.

[dnarvaez]

Milestone 0.98 deleted