Ticket #3654 (closed defect: fixed)

Opened 12 months ago

Last modified 11 months ago

Activity strings in global scope go untranslated

Reported by: dsd Owned by: erikos
Priority: Urgent Milestone: 0.96
Component: sugar-toolkit Version: 0.96.x
Severity: Major Keywords: 12.1.0, olpc-test-passed
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

As detailed in  http://lists.sugarlabs.org/archive/sugar-devel/2012-May/037678.html activity code is being imported before gettext is configured. This results in some activities displaying untranslated strings, such as Physics, which loads strings in global scope.

0.96 regression.

Attachments

0001-Move-the-translation-initialisation-to-an-earlier-st.patch Download (3.2 KB) - added by erikos 12 months ago.
toolkit-gtk3 patch
0001-Move-the-translation-initialisation-to-an-earlier-st.2.patch Download (2.2 KB) - added by erikos 12 months ago.
toolkit-patch

Change History

Changed 12 months ago by erikos

  • milestone changed from Unspecified by Release Team to 0.96

Changed 12 months ago by dsd

Looks good. When moving forward please add a comment in the sugar-activity addition explaining why gettext needs to be run so early, and similarly please explain in the shell patch why we load the value into the environment.

Changed 12 months ago by erikos

toolkit-gtk3 patch

Changed 12 months ago by erikos

toolkit-patch

Changed 12 months ago by erikos

  • priority changed from Unspecified by Maintainer to Urgent
  • severity changed from Unspecified to Major
  • status_field changed from Unconfirmed to Assigned

Ok, adjusted the patch now as Daniel suggested and added a comment. I have tested on the XO and both Clock and Physics are translated fine now.

Changed 12 months ago by erikos

We went back to removing the langpackdir feature. Adjusted the shell/toolkit/toolkit-gtk3 accordingly. Moved the initialisation of gettext into 'sugar-activity' so it happens early enough. Can be tested with Physics.

Is in: sugar-0.96.2, sugar-toolkit-0.96.3, sugar-toolkit-gtk3-0.96.3

Changed 12 months ago by erikos

  • keywords 12.1.0, olpc-test-pending added; 12.1.0 removed
  • status changed from new to closed
  • resolution set to fixed

Changed 12 months ago by erikos

Actually, sugar-toolkit-gtk3-0.96.4 should be used.

Changed 11 months ago by greenfeld

  • keywords olpc-test-passed added; olpc-test-pending removed

Translation of strings in Clock and Physics works again in 12.1.0 os13.

Note: See TracTickets for help on using tickets.