Ticket #3631 (closed defect: fixed)

Opened 12 months ago

Last modified 7 months ago

UserAgent of Browse contains "Sugar Labs/0.96"

Reported by: bernie Owned by: manuq
Priority: Low Milestone: 1.0
Component: Browse Version: 0.96.x
Severity: Unspecified Keywords:
Cc: erikos, bert, humitos Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

There's no clear standard for UserAgent strings, but embedding a space within one of its parts seems dangerous, because space is also used to separate such parts from one another.

I propose changing it to "Sugar/0.96", but "SugarLabs/0.96" would also do.

Change History

  Changed 12 months ago by bernie

  • cc erikos added
  • owner changed from erikos to manuq
  • status changed from new to assigned

Reassigning to manuq as I was told that he takes care of Browse nowadays.
Erikos, should we change the module owner in Trac to reflect this?

follow-up: ↓ 3   Changed 12 months ago by manuq

  • cc bert added

I don't have objections Bernie. We should change both, ASLO and Browse. Also, wasn't squeakland.org reading the User-Agent for Etoys projects too? Adding bert in the CC.

in reply to: ↑ 2 ; follow-up: ↓ 5   Changed 12 months ago by bernie

Replying to manuq:

I don't have objections Bernie. We should change both, ASLO and Browse. Also, wasn't squeakland.org reading the User-Agent for Etoys projects too? Adding bert in the CC.

I don't see anything equivalent to "Sugar Labs/0.96" in the UserAgent string of the versions of Browse based on xulrunner.

Now I'd be curious to know how ASLO detects the version of Sugar of the client.

  Changed 12 months ago by bert

Yes, Squeakland looks at the user agent - right now only for the substring "olpc" because newer Browse versions did not have any equivalent.

in reply to: ↑ 3   Changed 12 months ago by sascha_silbe

Replying to bernie:

I don't see anything equivalent to "Sugar Labs/0.96" in the UserAgent string of the versions of Browse based on xulrunner.

Yes, it broke some time ago, see SL#2834.

Now I'd be curious to know how ASLO detects the version of Sugar of the client.

See SL#1066 for the original patch for xulrunner based Browse.

As  explained on sugar-devel, we should use the  Sugar Platform version for the User-Agent header (i.e. SugarPlatform/0.96 rather than Sugar/0.96). Unfortunately, there's currently no good way to detect it.

  Changed 8 months ago by humitos

  • priority changed from Unspecified by Maintainer to Low

  Changed 8 months ago by humitos

  • cc humitos added

Ticket related:  http://dev.laptop.org/ticket/7684

  Changed 8 months ago by manuq

  • milestone changed from Unspecified by Release Team to 1.0

  Changed 8 months ago by erikos

Updated to 0.98 in current Browse:  http://git.sugarlabs.org/browse/mainline/commit/90dfa77823cfdf22661dea8379fab944508629e6

  Changed 7 months ago by alsroot

I've tweaked ASLO patch and updated production server
 http://git.sugarlabs.org/slo-activities/mainline/commit/f0299da4794371ac5cc4df15be2e8b965313ecf8

  Changed 7 months ago by manuq

  • status changed from assigned to closed
  • resolution set to fixed

Pushed Browse part as 6901af4e .

Note: See TracTickets for help on using tickets.