Ticket #3590 (closed defect: fixed)

Opened 13 months ago

Last modified 11 months ago

Sugar-artwork gtk3: Toggle button in the toolbar have wrong background when pressed.

Reported by: godiard Owned by: erikos
Priority: Normal Milestone: 0.96
Component: sugar-artwork Version: Git as of bugdate
Severity: Minor Keywords: 12.1.0, patch
Cc: garnacho Distribution/OS: OLPC
Bug Status: Assigned

Description

Yo can see in the gtk3 Read activity (v99), the toggle button with the star, is used to create/remove bookmarks. When pressed, should have a gray rounded square in the background, but show a black square.

Change History

Changed 13 months ago by erikos

  • owner changed from benzea to erikos
  • status changed from new to assigned

Changed 13 months ago by garnacho

FYI, I've just attached a patch in Ticket #3387 that also helps with this one, although this isn't exactly a dup either :)

Changed 12 months ago by erikos

  • keywords 12.1.0, patch added
  • version changed from Unspecified to Git as of bugdate

The patch in #3387  http://bugs.sugarlabs.org/attachment/ticket/3387/0001-Fix-artifacts-in-share-button-SL-3387.patch does display the gray background with rounded corners. The only difference now left is to make it slightly smaller than the border of the palette. But I am a bit stuck on that one.

Changed 12 months ago by godiard

Tested in Read activity. Please push.

Changed 12 months ago by erikos

  • priority changed from Unspecified by Maintainer to Normal
  • distribution changed from Unspecified to OLPC
  • severity changed from Unspecified to Minor
  • status_field changed from Unconfirmed to Assigned

Thanks Gonzalo for testing! I pushed the patch now with a more detailed description as:  http://git.sugarlabs.org/sugar-artwork/mainline/commit/54ef96860a93eb5c95ea019c12cd4dc388117398

I tried to use marging+padding to get the active highlight with a border as before but without success yet. So I would leave this one open. Severity for 0.96 I would say is minor now.

Changed 12 months ago by manuq

Gary gave positive feedback in today's dev meeting. Any more comments? Is current patch ok to land?

Changed 11 months ago by erikos

  • status changed from assigned to closed
  • resolution set to fixed

Fixed, as well verified by Manuel.

Note: See TracTickets for help on using tickets.