Read bookmark entry/edit Details area lacks border around text entry area

[greenfeld]

The Read activity's bookmark entry/edit Details area lacks a visible border around its text entry area.

The single-line bookmark title entry area does have a visible border.

Seen with a PDF file in OLPC 12.1.0 os8/Read-99.

[humitos]

I could reproduce this issue in XO 1.75 os12

[humitos]

TextView with borders

[humitos]

Not final patch, just an example

[humitos]

I don't know how to import this constant from Python (that is why I used just numbers):

•  http://developer.gnome.org/gtk3/3.0/GtkTextView.html#GtkTextView.description

and I don't know how to make the corners rounded. Maybe this is a theme issue. I'm not sure.

[humitos]

This is the correct patch - using the enumerates provided by Gtk (thanks manuq)

[humitos]

This is the correct patch - using the enumerates provided by Gtk (thanks manuq)

[erikos]

Ok, so we should probably do all of the theming of the dialog in sugar-artwork and revert the work around Gonzalo did inside Read in 0c4072cd9667222df883684ae26364c973c90773.

[humitos]

OK. I'm re-assigning this ticket to manuq, because he is on the theme.

[manuq]

What is not working is the set of the shadow type in a Gtk.ScrolledWindow, in Read readdialog.py is set as:

sw = Gtk.ScrolledWindow()
...
sw.set_shadow_type(Gtk.ShadowType.ETCHED_IN)

[manuq]

Found how to style the ScrolledWindow shadow, is in the second patch.

The first one fixes the theme so Read workaround in commit 0c4072cd9667222df883684ae26364c973c90773 can be removed.

[erikos]

Should we do a:

padding: $(default_padding)px;

to breath a bit more when taking bookmark notes :)

And yes, the Read patch can be removed with this fix.

[manuq]

Thanks for reviewing Simon, you are right about the padding. I attach a second version.

[manuq]

Second version of the ScrolledWindow frame styled.

[manuq]

Thanks, pushed.

[greenfeld]

The border is present in Read-99/OLPC 12.1.0 os16. Tested on XO-1 and XO-1.75.