Ticket #3553 (closed enhancement: fixed)

Opened 14 months ago

Last modified 9 months ago

Display only the url in the url entry

Reported by: erikos Owned by: humitos
Priority: Normal Milestone: 0.98
Component: Browse Version: Git as of bugdate
Severity: Unspecified Keywords: 12.2.0, design, patch
Cc: manuq, garycmartin, humitos Distribution/OS: OLPC
Bug Status: Unconfirmed

Description

The first versions of the Browse activity had no tabs. We needed a way to display the url and the title in the UI. We did a trick and used the hovering over the entry to switch between displaying the title or the url. This worked, but was subuptinmal and leaded to a few confusions.

The good news is, that now with tabs we have one more area where we can display such information, the tab. So like in Safari on the iPad we could reserve the url entry for the url and put the title in the tab.

Attachments

Change History

  Changed 9 months ago by humitos

  • cc humitos added
  • keywords 12.2.0, design added; 12.2.0 removed
  • priority changed from Unspecified by Maintainer to Normal

The width of the tab is not enough (mostly) to keep the complete title of the URL, so I think we should add a hover on it to display a palette with the complete title as well.

  Changed 9 months ago by humitos

  • owner changed from erikos to humitos
  • status changed from new to accepted

Changed 9 months ago by humitos

follow-up: ↓ 5   Changed 9 months ago by humitos

I had to add a new property in Browse class to save the url entered by the user. This is because if we switch over the tabs we will get a None uri if the page can not be loaded yet.

So, I'm saving the effective_url in this property (loading_url) and I'm showing it if browser.pops.uri is None.

  Changed 9 months ago by humitos

  • keywords design, patch added; design removed

in reply to: ↑ 3   Changed 9 months ago by manuq

  • status changed from accepted to closed
  • resolution set to fixed

Replying to humitos:

I had to add a new property in Browse class to save the url entered by the user. This is because if we switch over the tabs we will get a None uri if the page can not be loaded yet.

So, I'm saving the effective_url in this property (loading_url) and I'm showing it if browser.pops.uri is None.

Good, but I think the gobject property is unnecessary, using a conventional python class attribute instead is fine. I pushed it with this change as 5d018839 . Thanks!

Note: See TracTickets for help on using tickets.