Ticket #353 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

When resuming entry (image) with Browse show the mime type icon in the Naming Alert

Reported by: erikos Owned by: erikos
Priority: High Milestone: 0.84
Component: sugar-toolkit Version: 0.83.x
Severity: Major Keywords: r+
Cc: tomeu Distribution/OS: Unspecified
Bug Status: Resolved

Description

Tomeu - what do you think, does this make sense?

Attachments

353.patch Download (3.6 KB) - added by erikos 4 years ago.

Change History

Changed 4 years ago by tomeu

You mean to show in the naming icon the same icon that the entry will have in the journal, instead of always showing the activity icon? If so, makes sense and we can reuse the code in journal.misc to decide which icon to use.

Changed 4 years ago by erikos

Yup, that was the idea - was hard to explain :) Will have a look.

Changed 4 years ago by erikos

  • keywords r? added
  • version changed from Unspecified to 0.83.x
  • status_field changed from Unconfimed to Assigned

Changed 4 years ago by erikos

Changed 4 years ago by tomeu

  • keywords r+ added; r? removed

Sounds good, we'll reduce the amount of code involved there in 0.86 when we drop the custom mime stuff in sugar-base for gio.

Changed 4 years ago by erikos

  • status changed from new to closed
  • resolution set to fixed

Pushed  http://git.sugarlabs.org/projects/sugar-toolkit/repos/mainline/commits/780efa55b07e165af6664a16d193d22860b22dd6 and changed jarabe.journal.mime.py accordingly

Changed 4 years ago by erikos

  • status_field changed from Assigned to Resolved
Note: See TracTickets for help on using tickets.