Ticket #3526 (new defect)

Opened 13 months ago

Last modified 8 months ago

Correct theming for elements in Browse

Reported by: erikos Owned by: erikos
Priority: Normal Milestone: 0.96
Component: Browse Version: Git as of bugdate
Severity: Major Keywords: 12.1.0
Cc: manuq Distribution/OS: OLPC
Bug Status: New

Description

see screenshot

Attachments

Bildschirmfoto von _bugs_.png Download (79.8 KB) - added by erikos 13 months ago.
screenshot from bug tracker
browse-theme.JPG Download (121.2 KB) - added by erikos 13 months ago.
Browse theme with gtk2
browse-theme-gtk3.JPG Download (122.9 KB) - added by erikos 13 months ago.
browse theme with gtk3
patch Download (1.4 KB) - added by garnacho 12 months ago.
patch for sugar WebKit, unfortunately not suitable for upstream

Change History

Changed 13 months ago by erikos

screenshot from bug tracker

Changed 13 months ago by erikos

  • severity changed from Unspecified to Major
  • cc manuq added
  • component changed from untriaged to Browse
  • owner set to erikos
  • version changed from Unspecified to Git as of bugdate
  • milestone changed from Unspecified by Release Team to 0.96
  • keywords 12.1.0 added
  • distribution changed from Unspecified to OLPC
  • status_field changed from Unconfirmed to New

Changed 13 months ago by erikos

Browse theme with gtk2

Changed 13 months ago by erikos

browse theme with gtk3

Changed 12 months ago by garnacho

I'm attaching a tentative patch which resets form elements within a web view to the default GTK+ theme, as WebKit lacks the concept of a fallback theme. This needs to be done within WebKit (and not Browse/Ephy) because the GtkWidgetPaths created to theme the form elements are disconnected from the real widget hierarchy.

Changed 12 months ago by garnacho

patch for sugar WebKit, unfortunately not suitable for upstream

Changed 12 months ago by garycmartin

What would it take to make the Sugar theme work better in WebKit Browse? As that would seem like the idea design choice providing a unified and consistent Sugar UI experience.

Changed 12 months ago by garnacho

That's also a possibility, WebKit just needs theming for the limited set of elements that appear in forms, and AFAICS the most glaring problem is with radio/check buttons, it should be possible to install dedicated files to theme webkit that @include gtk-widget-${dpi}.css and forces downsizing of those elements.

Changed 8 months ago by humitos

  • priority changed from Unspecified by Maintainer to Normal
Note: See TracTickets for help on using tickets.