Ticket #3405 (closed defect: fixed)

Opened 14 months ago

Last modified 12 months ago

Read: when canceling the bookmark dialog I have to click twice the icon to reveal it again

Reported by: erikos Owned by: godiard
Priority: Unspecified by Maintainer Milestone: 0.96
Component: Read Version: Git as of bugdate
Severity: Major Keywords: 12.1.0, olpc-test-passed
Cc: Distribution/OS: OLPC
Bug Status: Unconfirmed

Description

Steps to reproduce:

- open a pdf in read

- click on the bookmark icon

- click on the cancel icon

- click again on the bookmark icon

---> no reaction

- click again on the bookmark icon

---> dialog opens

Change History

Changed 14 months ago by godiard

  • keywords 12.1.0, olpc-test-pending added; 12.1.0 removed
  • status changed from new to closed
  • resolution set to fixed

The bug have two sources.

First, the button used to add/remove the bookmark is a toggle, and the gtk3 theme is not setting the right grey color, then is not obvious to the user if the button is pressed or not.(this problem will be addressed in sugar-artwork)

The second problem is, if the user cancel the dialog creating the bookmark, the bookmark is not created but the button continue pressed until the page is changed. This was solved sending a signal to update the button state.

Two other problems were found and solved:

* The page number in the bookmark description was wrong by one.

* If the page had more than one bookmark, the clear method only removed the last then the sidebar accumulated bookmark icons.

Fixed in 743f1428db484972a2a9e9ba3e85d97c66cb76f4

Changed 12 months ago by greenfeld

  • keywords olpc-test-passed added; olpc-test-pending removed

I do not have a problem getting the bookmark dialog to work even when canceling it out in OLPC 12.1.0 os11/Read-99.

The page number in bookmarks is correct in PDF's; but not in epubs. Will file a separate ticket.

Note: See TracTickets for help on using tickets.