Ticket #3401 (closed defect: fixed)

Opened 14 months ago

Last modified 13 months ago

Browse crashes after loading a web page on XO-1

Reported by: manuq Owned by: manuq
Priority: Unspecified by Maintainer Milestone: 0.96
Component: Browse Version: Git as of bugdate
Severity: Blocker Keywords: 12.1.0, olpc-testing-pending
Cc: tonyforster Distribution/OS: OLPC
Bug Status: Assigned

Description (last modified by manuq) (diff)

I can reproduce this if I workaround #3400 setting a false title in line 123 of webtoolbar.py. This is for XO-1, after editing the entry and pressing enter, the page loads, then Browse crashes.

Trace attached.

Attachments

trace_browse.log Download (0.5 KB) - added by manuq 14 months ago.
sigill.patch Download (488 bytes) - added by erikos 14 months ago.
patch from  http://trac.webkit.org/changeset/113389/trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp
webkitgtk3.patch Download (1.2 KB) - added by erikos 14 months ago.
patch against f17 head

Change History

Changed 14 months ago by manuq

Changed 14 months ago by manuq

  • description modified (diff)

Changed 14 months ago by manuq

  • keywords 12.1.0 added

Changed 14 months ago by erikos

  • status_field changed from Unconfirmed to Assigned

I can reproduce the crash with epiphany on the XO-1, same error. Others seem to have encountered the same issue:  https://bugs.launchpad.net/ubuntu/+source/webkit/+bug/952216  https://bugs.launchpad.net/ubuntu/+source/epiphany-browser/+bug/950223

Changed 14 months ago by erikos

I can reproduce as well with: epiphany-3.4.0.1-1.fc17 webkitgtk3-1.8.0-1.fc17 Time to file upstream...

Changed 14 months ago by erikos

Filed as  https://bugs.webkit.org/show_bug.cgi?id=82496

Changed 14 months ago by manuq

  • summary changed from Browse crashes after loading a web page to Browse crashes after loading a web page on XO-1

Changed 14 months ago by erikos

Some more findings on the upstream bug  https://bugs.webkit.org/show_bug.cgi?id=82496 today:

The bug seems to be in the missing sse2 instructions set, missing sse registers on the Geode.

Foe now we can try to disable DFG (CPPFLAGS=-DENABLE_DFG_JIT=0).

Changed 14 months ago by manuq

Great work hunting, guys. Was fixed upstream, now we need to repackage it and test in build.

Changed 14 months ago by erikos

This is the patch we need while waiting for the upstream patch to bubble up:  http://trac.webkit.org/changeset/113389/trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp

Changed 14 months ago by erikos

I have patched webkitgtk3 [1] with the upstream patch [2]. This does fix the crashing for me on the XO-1.

[1]  http://koji.fedoraproject.org/koji/taskinfo?taskID=3987337
[2]  http://trac.webkit.org/changeset/113389/trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp

Changed 14 months ago by erikos

patch from  http://trac.webkit.org/changeset/113389/trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp

Changed 14 months ago by erikos

patch against f17 head

Changed 14 months ago by manuq

Great erikos, I have tested in build, after installing the RPM the issue disappears.

Changed 13 months ago by pbrobinson

This will be fixed in webkitgtk3-1.8.0-3.fc17

Changed 13 months ago by tonyforster

  • cc tonyforster added

Changed 13 months ago by erikos

  • keywords 12.1.0, olpc-testing-pending added; 12.1.0 removed
  • status changed from new to closed
  • resolution set to fixed

Has been landed in os8.

Note: See TracTickets for help on using tickets.