Turtle Art collaboration breaks when a turtle is manually dragged

[garycmartin]

While trying to reproduce some bugs from last week in Turtle Art 114, version 116 seems to have now lost almost all ability to share turtles. When collaborating between 11.3.0 build 8 XO-1.75 and an XO-1, I'm seeing the two Turtles of each collaborator appear, but I get perhaps at best only one event transmitted, then nothing more. Running simple code, dragging a turtle position, nothing updates on the other client. Logs have no interesting messages/errors.

[garycmartin]

After leaving the two machines for 5min, the two TA clients appear to have started to synchronise... Hmmm.

[garycmartin]

Problem appears to be triggered if you try and drag either of the turtles on screen, comms between the two clients seems to stop for a number of minutes and then catches up again.

[walter]

Is that problem new to v116 or did it happen in v114 as well? I'll investigate in any case, but it would be good to know if it was due to some change I made.

Thanks for testing.

[garycmartin]

Replying to walter:

Is that problem new to v116 or did it happen in v114 as well? I'll investigate in any case, but it would be good to know if it was due to some change I made.

Just retested in v116 and v114. Re-confirmed that dragging any turtle in either version stalls out collaboration. Sometimes the drawing event history catches up after perhaps 1min or so, other times you start getting new events only, and sometimes the clients never reconnect (I'm only testing with two TA clients at the moment). If you avoid dragging a turtle, collaboration seems reasonably robust between two clients.

[walter]

With this patch, I don't share the turtle position/orientation until the button is released.

 http://git.sugarlabs.org/turtleart/mainline/commit/5ddf2801aac28eb244126bfc3bf36686ca76ca06

Thus, rather than flooding the network with each change in position, it is only necessary to send one update. Seems to have fixed the problem.

[walter]

Fixed in v117