Paint: undo does not work reliably

[erikos]

I have been using today Paint for a while and 'undo' has not been working for me reliably. Sometimes more than one step did get undone. For example I did color different areas (with the bucket tool) and then did press 'undo' and it jumped back too an older version and did not just undo the last step.

Paint version 36

[humitos]

Yes, I can confirm this. I've just tested it on XO 1.75 os12 and Undo is not working properly.

In fact, if you

1. color different areas as erikos said
2. press the Undo button
3. color some new areas

The ability to Undo again is lost. You just can click on Redo and it does "something strange".

[humitos]

This patch solves this issue, but there is a case that I couldn't find yet:

1. Draw anything in 5 steps. For example, five lines
2. Click twice on "Undo"
3. Click once on "Redo"

The "Redo" action will not work. But if you press this button again you will see the "Redo" action done. I'm pretty sure that it's related with the index (self._undo_index) of the self._undo_list but I couldn't fix it yet.

[humitos]

I added a patch that adds a new Spin Button to show every "undo item" in the self._undo_list. This is useful to test if the "undo item" is being shown or not.

I don't know why but every time that I use the bucket twice and click on "Undo" both of the fills are undone. After that when I press on "Redo" just the first one is redone.

[humitos]

This patch solves this issue

[manuq]

Thanks! Pushed.

[greenfeld]

Undo and redo support seems to work properly in Paint in 12.1.0 os18.