Journal: add support for copying to Documents folder (detail view, copy-to palette)

[greenfeld]

The Journal item detail view can copy items to a USB stick (if inserted) and the Clipboard. But it cannot copy the currently active item to the Documents folder if said folder is available from the main Journal list view.

Seen in 11.3.0 os3.

[erikos]

Yes, this is known. Would be a bigger change to add support for that. Moving out to 0.96.

[humitos]

This patch is not finished. I don't know how to get the "selected_volume" yet

[humitos]

v2 - adds the same behaviour on toolbox's icon

[humitos]

I implemented this behaviour but the value of "selected_folder" variable is missing. I don't know how to (or from where) get it.

This patch adds the same code in two different files and that is not so good. Actually, there are repeated old code on those files that this patch touches.

[godiard]

Add new version (v3) of patch, with the pending issue solved. Now only show the option when needed.

[godiard]

Simon, new patch version, I think ready to include.

[erikos]

Pushed as b01cd3e080a0df6d046057c67b6fb7ff7b0daa63 Changed the icon to be black and white after discussing with Gary.

erikos: garycmartin: the document icon in the Palette, should it be owner-coloured or bw? 
garycmartin: erikos: re document icon in the Palette, owner-coloured or bw? Hmmmm, clip board and USB sticks are showing as B&W at the moment, so for now stick with B&W for the Documents folder, though I'd say really USB sticks and Documents folder should be in user colour (to matches how they are show in the journal volumes toolbar/frame).
erikos: garycmartin: yeah, I had similar thinking 
erikos: garycmartin: but clipboard, is my clipboard as well right?
erikos: garycmartin: why should that be bw?
garycmartin: erikos: The clipboard icon really doesn't work well in user colours, I tried once before, it's just a single fill colour with no outline.
erikos: garycmartin: ok, I feared such an answer
erikos: garycmartin: so, I would vote for bw for the document folder as well
erikos: garycmartin: to have a consistent Palette there
garycmartin: erikos: needs a new icon for that, and then raises the question if it should also be coloured in Activity toolbars...
garycmartin: erikos: +1

Thanks everyone!

[greenfeld]

The copy-to-journal option exists in OLPC 13.1.0 os27.

[greenfeld]

The copy-to-documents folder option rather.