Activity Frame title does display "sugar activity"

[erikos]

this is an issue in current head introduced by d0a493e5326cf9b4c5cd6470242fd25665fdf1ed

I think the following does fix it - but needs more testing as we regressed already several times:

diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index 2c7d823..4ea7570 100644
--- a/src/sugar/activity/activity.py
+++ b/src/sugar/activity/activity.py
@@ -343,6 +343,7 @@ class Activity(Window, gtk.Container):
             self._jobject.metadata['title'] = self.shared_activity.props.name
             self._jobject.metadata['icon-color'] = \
                 self.shared_activity.props.color
+        else:
             self.set_title(self._jobject.metadata['title'])
             self._jobject.metadata.connect('updated',
                                            self.__jobject_updated_cb)

[erikos]

|TestCase|

• open an activity (e.g. Memorize)

• change it's title in the Journal

• open the activity palette in the tray

---> the activity should be up-to-date there

• change the title in the activity

• change focus (e.g. go to the neighborhood view and back, see ​http://dev.laptop.org/ticket/11087 why)

• open the activity palette in the tray

---> the activity should be up-to-date there

[erikos]

Has been pushed as: c1f9d716ab04821898ee4a61afd2203f39803b65 and a follow up patch was 1609340503ed353f09ba621aa6ace77aad8c1bb1 see #3109

[dnarvaez]

Milestone 0.94 deleted