Ticket #3037 (closed defect: fixed)

Opened 23 months ago

Last modified 22 months ago

Distance fails to start measuring

Reported by: greenfeld Owned by: RafaelOrtiz
Priority: Unspecified by Maintainer Milestone: Unspecified by Release Team
Component: Distance Version: 0.92.x
Severity: Major Keywords: 11.3.0
Cc: Distribution/OS: OLPC
Bug Status: Unconfirmed

Description (last modified by greenfeld) (diff)

Distance-23 fails to start measuring on OLPC 11.3.0 os2. (Version number was wrong initially.)

Both the starting computer and the one joining the shared session log the following exception:

Traceback (most recent call last):

File "/home/olpc/Activities/Distance.activity/activity.py", line 291, in _helper_thread

dt = arange.measure_dt_seq(self.main_socket, self.initiating, self._change_message)

File "/home/olpc/Activities/Distance.activity/arange.py", line 418, in measure_dt_seq

mls = compute_mls(R)

File "/home/olpc/Activities/Distance.activity/arange.py", line 84, in compute_mls

return LFSR(Rf, [i - 1 for i in taps[n]], 2**n - 1)

NameError: global name 'Rf' is not defined

Attachments

0001-removed-spam-introduced-by-Commit-efd02466335d8f8677.patch Download (2.4 KB) - added by walter 23 months ago.
patch to remove spurious 'f' characters scattered throughout the file

Change History

Changed 23 months ago by walter

patch to remove spurious 'f' characters scattered throughout the file

Changed 23 months ago by walter

Rafael, you must have not applied the attached patch which cleans up errors introduced here:

 http://git.sugarlabs.org/distance/distance/commit/efd02466335d8f8677d73b8e04bdeefb310aaa48

But upon closer examination, it seems you did apply the patch:

 http://git.sugarlabs.org/distance/distance/commit/f53ad6ef6d23ed069def5c89955fe61069cbc4ff

I don't know how those typos are back in the code.

Changed 23 months ago by RafaelOrtiz

Maybe greenfield is not trying with an updated repo ?

 http://git.sugarlabs.org/distance/distance/blobs/master/arange.py

mainline shows the corrected version.

Changed 23 months ago by greenfeld

If it is fixed in a new activity release please ask dsd or erikos to pull it.

At the moment we should just be pulling the latest from ASLO, and ASLO lists Distance-23 from May 2011 as the latest.

Changed 23 months ago by greenfeld

  • description modified (diff)

Changed 23 months ago by greenfeld

Distance-23 as downloaded from ASLO right now does not appear to have this patch:

    return LFSR(Rf, [i - 1 for i in taps[n]], 2**n - 1)
    returnf (rec_process, f)
    rec_profcess.wait()

Changed 23 months ago by RafaelOrtiz

Packaged in V24 of distance.

Changed 22 months ago by RafaelOrtiz

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.