Cursor moves to beginning while trying to edit activity instance name

[m_anish]

When we try to edit the activity instance name to save a meaningful journal entry, the cursor moves to the beginning of the line after every 3-4 keystrokes.

Seen on Dextrose-2 XO-1 and XO-1.5

[sascha_silbe]

Probably a dupe of #1948.

[alsroot]

Replying to sascha_silbe:

Probably a dupe of #1948.

And we already have this fix in dx-2

[alsroot]

In Write's title widget it works fine on dx2 on XO-1/1.5.
m_anish: are there any errors in shell.log and activity log while you can reproduce the issue?

[m_anish]

Write Activity: log 1

[m_anish]

Write Activity: log 2

[m_anish]

shell.log

[m_anish]

Terminal activity log

[m_anish]

Moon activity log

[m_anish]

Replying to alsroot:

This issue seems limited to Write activity. See all the logfiles attached. Reproduced on XO-1; dx-2

[alsroot]

Patch was sent to sugar-devel@.
Removing any dx related metadata since patch is applied to dx-2 repo.

[dsd]

I briefly revisited old discussions on this issue and I did some thinking, and I think the following approach is sensible:

• If the instance name textbox has the gtk.HAS_FOCUS flag, ignore all updates from datastore (don't update title)
• Update the title widget with the new title if the datastore sends an update and the textbox isn't focused

• Write the new title to the datastore on the focus-out event.
• If editing the title then clicking the Stop button doesn't cause a focus-out event, and it can't be seen how to obviously make that focus-out event occur before Stop's clicked event is triggered, make the activity stop handler look for changes in the activity title and update the datastore if necessary

I think this should solve all the issues that were raised before, but I might have missed something.

[erikos]

Review done on irc, pushed as:

 http://git.sugarlabs.org/sugar-toolkit/mainline/commit/746325106fb96fb9a4ad8fb45210dc1a60110ae8

 http://git.sugarlabs.org/sugar-toolkit/mainline/commit/7a0d5d93984003d9d5964f593886dc6dee6dfb39

[erikos]

#2914 is a follow up issue about a minor glitch.

[erikos]

Can be tested in build os871.