save fails with None buddy reference

[walter]

I joined a seeming phantom shared activity and got this error when quitting:

1297121383.895540 ERROR root: Error saving activity object to datastore
Traceback (most recent call last):

File "/usr/lib/python2.7/site-packages/sugar/activity/activity.py", line 823, in _prepare_close

self.save()

File "/usr/lib/python2.7/site-packages/sugar/activity/activity.py", line 642, in save

buddies_dict = self._get_buddies()

File "/usr/lib/python2.7/site-packages/sugar/activity/activity.py", line 617, in _get_buddies

buddy_id = sha1(buddy.props.key).hexdigest()

TypeError: must be string or buffer, not None

We should catch the None buddy instance.

[walter]

I confirmed that there was a buddy.props.key with value None.

Adding a simple test for None seems to remedy the problem but doesn't necessarily address the root cause:

if buddy.props.key is not None:

buddy_id = sha1(buddy.props.key).hexdigest()
buddies[buddy_id] = [buddy.props.nick, buddy.props.color]