Ticket #245 (assigned defect)

Opened 4 years ago

Last modified 6 weeks ago

show spinning cursor when opening the languages cp section

Reported by: tomeu Owned by: manuq
Priority: normal Milestone: 0.98
Component: sugar Version: Git as of bugdate
Severity: Major Keywords: regression, r?
Cc: smparrish, erikos Distribution/OS: Unspecified
Bug Status: Needinfo

Description (last modified by walter) (diff)

Attachments

Change History

  Changed 4 years ago by tomeu

  • keywords sugar-love added
  • distribution set to Unspecified
  • severity set to Blocker
  • status_field set to Unconfirmed

  Changed 4 years ago by tomeu

  • severity changed from Blocker to Major

  Changed 3 years ago by km0r3

  • owner changed from tomeu to km0r3
  • status changed from new to accepted
  • status_field changed from Unconfirmed to Needinfo

I'd like to work on this one to get started, if still relevant.

I'm using sugar on Ubuntu from the PPA repositories and freshly (successfully) built sugar-jhbuild, with sugar 0.87.7 as the testing environment.

I don't see any spinning cursor when visiting the Languages section in the CP with the current version, so I suppose this Ticket still needs attention.

Also loads seemingly fast here, so why a spinning cursor?

Please treat me gently for the moment, as I'm very new here. ;-)

  Changed 3 years ago by km0r3

  • milestone changed from 0.86 to 0.88

  Changed 3 years ago by quozl

Tested the delay in rendering the languages control panel section; that is the time that elapses from when the user clicks on the languages icon in the control panel to when the languages list is available for interaction.

Sugar VersionHardwareResponse Time
0.82.1XO-1approx 1000ms
0.84.11XO-1.5approx 250ms
0.87.8sugar-emulator over X over SSHapprox 250ms

Given the frequency of use of the languages control panel section, and the time it currently takes, I don't think it is worth adding spinning cursor feedback.

Or maybe I've misunderstood the requirement.

  Changed 3 years ago by cjl

As for the requirement, this relates back to #51

  Changed 3 years ago by tomeu

  • status changed from accepted to closed
  • resolution set to fixed

  Changed 3 years ago by tomeu

  • status changed from closed to reopened
  • resolution fixed deleted

  Changed 3 years ago by tomeu

Sorry, have just had to revert it because we are in freeze. We need to remember to push this one once the freeze finishes.

  Changed 3 years ago by smparrish

  • cc smparrish added

  Changed 3 years ago by smparrish

  • seeta_dev set to Ishan

  Changed 2 years ago by adborden

Looks like this was re-applied to mainline in September dd0fcdc103cdbeb052094e66e7812c786fe23e07

  Changed 3 months ago by manuq

  • cc erikos added
  • keywords regression, r? added; sugar-love removed
  • status changed from reopened to assigned
  • owner changed from km0r3 to manuq
  • milestone changed from 0.88 to 0.98

While looking at #4327 I came across this one as well. Commit dd0fcdc1 says it fixes this, but currently is not working. The attached patch takes commit df126bad as reference and wraps the time consuming action in a function which is called with idle_add. I have also added a blank canvas while the section is loading.

follow-up: ↓ 15   Changed 3 months ago by erikos

Where did you test this, on an XO-1? On my other systems I did not have issues with long waiting times?

The modem configuration section leaves a never ending spinning cursor. Looks like a regression, works without the patch.

in reply to: ↑ 14   Changed 3 months ago by manuq

Replying to erikos:

Where did you test this, on an XO-1? On my other systems I did not have issues with long waiting times?

The affected section is Language, and yes, is specially noticeable in XO-1, and gets worse with more languages. By the way I have ongoing patches for #4327 to improve this specific section. Happens too testing the patch for the proposed Background feature:

 http://wiki.sugarlabs.org/go/Features/Background_image_on_home_view


The modem configuration section leaves a never ending spinning cursor. Looks like a regression, works without the patch.

Good catch! Yes I was checking and this happens because of the while loop that calls Gtk.main_iteration() [1] in that section model.py .

[1]  https://developer.gnome.org/gtk3/stable/gtk3-General.html#gtk-main-iteration

Changed 8 weeks ago by walter

  Changed 8 weeks ago by walter

I think the attached mod is a bit simpler and it seems to work. Please test.

  Changed 8 weeks ago by walter

  • description modified (diff)

  Changed 8 weeks ago by walter

  • description modified (diff)

  Changed 6 weeks ago by walter

 https://github.com/sugarlabs/sugar/pull/53 address the issue with modem configuration (see #3800).
 https://github.com/sugarlabs/sugar/pull/54 adds the WATCH cursor

Note: See TracTickets for help on using tickets.