Ticket #2446 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Journal toolbar search field should expand to consume available space

Reported by: garycmartin Owned by:
Priority: Unspecified by Maintainer Milestone: Unspecified by Release Team
Component: untriaged Version: Unspecified
Severity: Minor Keywords: olpc-0.90 r+
Cc: erikos Distribution/OS: Unspecified
Bug Status: Resolved

Description

This looks like a design regression from previous Sugar releases that I think slipped in with the addition of the new sort options icon. Attached a screen shot taken on an XO-1 running the F14 test 0.90 build.

Attachments

Journal toolbar.png Download (20.1 KB) - added by garycmartin 3 years ago.
Journal_toolbar_after_removing_expanding_separator.png Download (81.0 KB) - added by garycmartin 3 years ago.
0001-Remove-separator-so-Journal-search-field-fills-avail.patch Download (1.5 KB) - added by garycmartin 3 years ago.
Patch removing toolbar separator and the _add_separator method.

Change History

Changed 3 years ago by garycmartin

  Changed 3 years ago by garycmartin

Looking at /usr/lib/python2.7/site-packages/jarbe/journal/journaltoolbox.py at about line number 112, there is a:

self._add_separator(expand=True)

Remove this, and the search field is correctly expanding to fill the available space again. See attached screen shot.

Changed 3 years ago by garycmartin

  Changed 3 years ago by garycmartin

  • cc erikos added
  • keywords r? added

Just a ping to see if this can land at all.

follow-up: ↓ 4   Changed 3 years ago by erikos

  • keywords r+ added; r? removed

Looks good. As the _add_separator method is not used anymore we can remove it. r+ with that change

Changed 3 years ago by garycmartin

Patch removing toolbar separator and the _add_separator method.

in reply to: ↑ 3   Changed 3 years ago by garycmartin

Replying to erikos:

Looks good. As the _add_separator method is not used anymore we can remove it. r+ with that change

Fab :) git format-patch attached with both the separator line, and the _add_separator method removed.

  Changed 3 years ago by erikos

  • status changed from new to closed
  • resolution set to fixed
  • status_field changed from Unconfirmed to Resolved
Note: See TracTickets for help on using tickets.