sugar-emulator's window title is 'xephyr on…' instead of sugar

[lfaraone]

Forwarded from  https://launchpad.net/bugs/617805:

"""
To reproduce the bug follow these steps-
1. Run sugar emulator.
2. Check the bottom bar of window.

Resolution: It should display 'Sugar'.
"""

I'm also including a patch by Ishan that fixes the issue.

[sascha_silbe]

I would prefer a title like "Sugar inside Xephyr" or "Sugar in a window". There's a lot of confusion between the different ways to build (distro packages or sugar-jhbuild) and run (natively or sugar-emulator) Sugar so we need to be clear about what is what. A lot of people even seem to think that sugar-emulator emulates the XO-1 hardware in some way (no doubt due to the name).
If you include menu entries for running Sugar in the Debian/Ubuntu distro packages, please take the above into account (e.g. name it "Run Sugar in a window").

As to the patch, it would be nice to have the two new parameters on a single line as they belong together.
E.g.:

    cmd += ['-title', 'Sugar inside Xephyr']

[lfaraone]

Revised patch. (authored by Ishan Bansal)

[tomeu]

+1 to "Sugar in a window" as Xephyr is an implementation details that the user doesn't need to know about and may change in the future.

Also note that you need to put that string between _() so it's included for translation.

And finally, please create the patch with git format-patch.

[tomeu]

Pushed as  http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/003ef4fd

Thanks!

[bernie]

This change disables the informative titlebar message "ctrl+shift grabs/releases mouse and keyboard", without which the emulator is unusable.

I looked at the Xephyr code: after setting a user title, there's no way to make the message toggle automatically. Therefore, I recommend reverting this patch.

[sascha_silbe]

Replying to bernie:

This change disables the informative titlebar message "ctrl+shift grabs/releases mouse and keyboard", without which the emulator is unusable.

I looked at the Xephyr code: after setting a user title, there's no way to make the message toggle automatically. Therefore, I recommend reverting this patch.

We should file a ticket against Xephyr and work around it by adding the above message to the title.