metadata-only update sets filesize property to 0

[garycmartin]

Testing the latest dextrose 373pyg, when setting the Journal sort option to "View by size" and editing the name of any entry, it's size is reset to "Empty". Only by resuming the entry will the size correctly show again.

Steps to reproduce:

- switch to Journal
- right click on the "Sort by" icon (FWIW 373pyg has the button incorrectly labeled "List view")
- select "View by size"
- click on the text name of any Journal entry to edit it
- press return to OK the edit (don't actually need to change the text)
- the Journal entry will now show as size "Empty"

[garycmartin]

Note the renamed screenshot entries are all now showing "Empty", they were showing the correct size before being renamed.

[erikos]

Thanks for your report, Gary! Reproduced with the latest patches here.

- right click on the "Sort by" icon (FWIW 373pyg has the button incorrectly labeled "List view")

What would be the correct labeling here?

[garycmartin]

Replying to erikos:

Thanks for your report, Gary! Reproduced with the latest patches here.

{{{
- right click on the "Sort by" icon (FWIW 373pyg has the button incorrectly labeled "List view")
}}}

What would be the correct labeling here?

Sorry, you're going to hate me, but you did ask ;)

Sort view

---

Sort by date modified
Sort by date created
Sort by size

[erikos]

Replying to garycmartin:

Replying to erikos:

Thanks for your report, Gary! Reproduced with the latest patches here.

{{{
- right click on the "Sort by" icon (FWIW 373pyg has the button incorrectly labeled "List view")
}}}

What would be the correct labeling here?

Sorry, you're going to hate me, but you did ask ;)

Sort view
------------
Sort by date modified
Sort by date created
Sort by size

Those are easy changes - attached screenshot to other ticket.

[aa]

This bug is caused by the journal calling model.write with a default file_path argument:

    def __cell_title_edited_cb(self, cell, path, new_text):
        row = self._model[path]
        metadata = model.get(row[ListModel.COLUMN_UID])
        metadata['title'] = new_text
        model.write(metadata, update_mtime=False)
        self.cell_title.props.editable = False

The default_file path is , and so the filesize is updated with an inexistent file.

def write(metadata, file_path='', update_mtime=True, transfer_ownership=True):
...
         if metadata.get('uid', ''):
             object_id = _get_datastore().update(metadata['uid'],
                                                  dbus.Dictionary(metadata),
                                                  file_path,
                                                  transfer_ownership)

The attached patch fixes this.

[sascha_silbe]

Replying to aa:

The default_file path is , and so the filesize is updated with an inexistent file.

That's a bug in the data store then. Passing file_path= for an entry that already has data means updating the metadata only and leaving the data unchanged (see  carquinyol.filestore.FileStore.store(); especially notice the commented out part).
If we change the API to not support metadata-only updates anymore, more than just the Journal will break.

[alsroot]

yeah, missed that while reviewing ds patch

 http://git.sugarlabs.org/projects/sugar-datastore/repos/mainline/commits/b41b809b8d48a737e520c01007085af954d0f6b8