Ticket #2180 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Sugar emulator, when run on 800x600 resolution, faces cropping

Reported by: dipankar Owned by: dipankar
Priority: High Milestone: 0.90
Component: sugar Version: 0.88.x
Severity: Major Keywords:
Cc: aslroot, dfarning, sascha, tomeu Distribution/OS: Ubuntu
Bug Status: Assigned

Description (last modified by dipankar) (diff)

Bug Description:
When the system resolution is changed to 800x600, and the emulator is ran, the emulator window is pushed down out of visible area. This leads to a situation where the bottom portion of the emulator is not visible.

This is a specific issue that only happens because the emulator resolution is the same at the monitor resolution.

Probable reason:
The task panels of Ubuntu and title bar of emulator window, are pushing the window downward, leaving reduced visible space for sugar.

Steps to reproduce:
1. Set the system resolution to 800x600.
2. Start the emulator.
3. Some portion from bottom in Sugar is not visible.

Attachments

0001-fullscreen-workaround.-Ticket-2180.patch Download (0.9 KB) - added by dipankar 3 years ago.
workaround patch for the bug

Change History

Changed 3 years ago by dipankar

  • owner changed from tomeu to dipankar
  • status changed from new to assigned

Changed 3 years ago by dipankar

  • distribution changed from Unspecified to Ubuntu

Changed 3 years ago by dipankar

workaround patch for the bug

Changed 3 years ago by dipankar

  • cc sascha, tomeu added
  • keywords r? added; fullscreen, cropping removed
  • status_field changed from Unconfirmed to New

Patch uploaded and requesting for review

Changed 3 years ago by sascha_silbe

Looks good to me. While it's still not a complete fix, it's about as good as we can do (since we can't know the size of the window decorations).

Changed 3 years ago by tomeu

  • keywords r! added; r? removed

What happened with adjusting the grid cell size so the UI fits in 800x600?

Changed 3 years ago by dipankar

  • priority changed from Unspecified by Maintainer to High
  • severity changed from Unspecified to Major
  • status_field changed from New to Assigned
  • description modified (diff)
  • milestone changed from Unspecified by Release Team to 0.88

Changed 3 years ago by sascha_silbe

  • keywords r? added; r! removed

Changed 3 years ago by tomeu

  • keywords r! added; r? removed

The code change looks good to me, but please attach first one with an appropriate commit message.

Changed 3 years ago by dipankar

I have sent the proper patch based on mainline to sugar-devel mailing list.
Requesting a review.

Changed 2 years ago by sascha_silbe

  • keywords r! removed
  • status changed from assigned to closed
  • resolution set to fixed
  • milestone changed from 0.88 to 0.90

Fixed by  1d069eb (master) /  1cce2c7 (sucrose-0.90).

Note: See TracTickets for help on using tickets.