Ticket #2150 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Examples should follow the sugar coding guidelines

Reported by: erikos Owned by: lfaraone
Priority: Unspecified by Maintainer Milestone: Unspecified by Release Team
Component: Pippy Version: Unspecified
Severity: Unspecified Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

It would be great if the Pippy examples could follow the Sugar coding guidelines (and pylint, pep8). For example: 'a=3' should be 'a = 3' and so on.

Change History

Changed 3 years ago by quozl

I disagree. Pippy examples should not follow Sugar coding guidelines, but should follow pylint and pep8.

Changed 2 years ago by RafaelOrtiz

+1, examples must follow pylint and pep8 not necessarily. sugar coding guidelines.

Changed 2 years ago by RafaelOrtiz

Some pep8 fixes already in mainline

 http://git.sugarlabs.org/pippy/mainline/commit/bab3cb00234c268d966bed5d6b2b43b0222da2c6

Changed 2 years ago by RafaelOrtiz

  • status changed from new to closed
  • resolution set to fixed

I've reviewed the data examples and committing some pep8 fixes.

all are pep8 clean (ignoring E501)

Fixing this.

Changed 2 years ago by erikos

Thanks Rafael for working on this.

Note: See TracTickets for help on using tickets.