Ticket #2086 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

mesh device icon always shows active state

Reported by: dsd Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: Unspecified by Release Team
Component: sugar Version: Unspecified
Severity: Unspecified Keywords: olpc-0.84
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

The mesh icon is always showing the device as active. Looks like I uploaded the wrong patch during the review stages.

Attachments

Change History

Changed 3 years ago by dsd

fix

Changed 3 years ago by erikos

  • keywords r+ added; r? removed
  • status_field changed from Unconfirmed to Assigned

Thanks Daniel for the patch. The code looks good and it is working well.

I even wonder a bit if we need to show the device at all when we are not connected. That is what we do for the wired device for example. And I think we show the wireless device only because we have the 'create new network' option in there. I remember Eben had a full and convincing view on those things. Maybe you can get his input.

If time critical, I would argue that you can push your code to at least the 0.84 branch, as it fixes the bug.

Changed 3 years ago by erikos

  • keywords r+, olpc-0.84 added; r+ removed

Changed 3 years ago by dsd

  • keywords r+, removed

Good point. With agreement from Tomeu, I've pushed out the patch to master and 0.84 because it's an improvement on the behaviour we have already (mesh device always shown in frame). I'll start a design discussion now regarding hiding it when not in use (sounds like a good idea to me too) and will follow up with further patches if we decide to change.

Changed 3 years ago by erikos

Awesome, thanks Daniel!

Changed 3 years ago by dsd

  • status changed from new to closed
  • resolution set to fixed

filed #2094 to hide the device when not in used.

Note: See TracTickets for help on using tickets.