Trying to register to XS while offline produces in no user visible errors

[bernie]

How to reproduce:

1. start sugar
2. ensure the network is down
3. select Register from the buddy icon menu

shell.log contains:

Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/jarabe/desktop/favoritesview.py", line 323, in __register_activate_cb
    schoolserver.register_laptop()
  File "/usr/lib/python2.6/site-packages/jarabe/desktop/schoolserver.py", line 101, in register_laptop
    data = server.register(sn, nick, uuid_, profile.pubkey)
  File "/usr/lib/python2.6/xmlrpclib.py", line 1199, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.6/xmlrpclib.py", line 1483, in __request
    allow_none=self.__allow_none)
  File "/usr/lib/python2.6/xmlrpclib.py", line 1132, in dumps
    data = m.dumps(params)
  File "/usr/lib/python2.6/xmlrpclib.py", line 677, in dumps
    dump(v, write)
  File "/usr/lib/python2.6/xmlrpclib.py", line 699, in __dump
    f(self, value, write)
  File "/usr/lib/python2.6/xmlrpclib.py", line 703, in dump_nil
    raise TypeError, "cannot marshal None unless allow_none is enabled"
TypeError: cannot marshal None unless allow_none is enabled

[timclicks]

fix

[bernie]

 http://patchwork.sugarlabs.org/patch/164/

[tomeu]

Could someone clarify which of the two patches is being proposed?

[tomeu]

Removing from the queue until it's clear which is the patch awaiting for review.

[timclicks]

Replying to tomeu:

Removing from the queue until it's clear which is the patch awaiting for review.

Sorry for not responding to your earlier comment. This is the patch for review:

src/jarabe/desktop/schoolserver.py

@@ -99 +99 @@
     server = ServerProxy(url)
     try:
         data = server.register(sn, nick, uuid_, profile.pubkey)
-    except (Error, socket.error):
+    except (Error, TypeError, socket.error):
         logging.exception('Registration: cannot connect to server')
         raise RegisterError(_('Cannot connect to the server.'))

[tomeu]

Pushed, thanks. Next time please generate the patch with git format-patch, more details in  http://wiki.sugarlabs.org/go/Development_Team/Code_Review