Ticket #19 (closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

add star badge to APs that are in our connections

Reported by: erikos Owned by: erikos
Priority: normal Milestone: 0.86
Component: sugar Version: Git as of bugdate
Severity: Minor Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

each AP that is in our connections config file needs to have a star badge (favi icon)

Change History

Changed 4 years ago by erikos

  • owner changed from marcopg to erikos
  • priority changed from major to normal
  • version set to Git as of bugdate
  • status changed from new to assigned
  • milestone set to 0.84

Changed 4 years ago by gregdek

  • distribution set to Unspecified
  • type changed from defect to enhancement
  • severity set to Blocker
  • status_field set to Assigned

Not major. Moving to 0.86 release.

Changed 4 years ago by tomeu

  • milestone changed from 0.84 to 0.86

Moving to 0.86 as per Greg's comment

Changed 4 years ago by erikos

  • cc r? added
diff --git a/src/jarabe/desktop/meshbox.py b/src/jarabe/desktop/meshbox.py
index c37bba1..be33d0f 100644
--- a/src/jarabe/desktop/meshbox.py
+++ b/src/jarabe/desktop/meshbox.py
@@ -217,7 +217,10 @@ class AccessPointView(CanvasPulsingIcon):
         logging.debug('Error getting the access point properties: %s', err)
 
     def _update(self):
-        if self._flags == network.NM_802_11_AP_FLAGS_PRIVACY:
+        if network.find_connection(self._name) != None:
+            self.props.badge_name = "emblem-favorite"
+            self._palette_icon.props.badge_name = "emblem-favorite"
+        elif self._flags == network.NM_802_11_AP_FLAGS_PRIVACY:
             self.props.badge_name = "emblem-locked"
             self._palette_icon.props.badge_name = "emblem-locked"

Changed 4 years ago by erikos

  • severity changed from Blocker to Minor

Changed 4 years ago by tomeu

  • cc r? removed
  • keywords r? added

Changed 4 years ago by tomeu

  • keywords r+ added; r? removed

None is a singleton, so better do "is not None" instead of !=, see PEP for a longer explanation.

r+ with that nitpick

Changed 4 years ago by tomeu

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.