Ticket #1862 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Unneeded debug logs

Reported by: erikos Owned by: alsroot
Priority: Unspecified by Maintainer Milestone: 0.90
Component: journal Version: Unspecified
Severity: Minor Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description 

src/jarabe/journal/model.py:188:            logging.debug('cache hit and no need to grow the cache')
src/jarabe/journal/model.py:111:        logging.debug('ResultSet.read position: %r', self._position)

I think we can remove those debug logs. They clutter the logs and don't bring as much value, imho.

Attachments

0001-Remove-unneeded-journal-debug-logs-1862.patch Download (1.1 KB) - added by erikos 3 years ago.
Patch against master

Change History

  Changed 3 years ago by tomeu

  • owner changed from tomeu to alsroot
  • component changed from sugar to journal

missing patch?

follow-up: ↓ 3   Changed 3 years ago by erikos

  • keywords r! added; r? removed

Aleksey can you comment if you agree on my assumption that those logs are not necessary? If yes I will do a patch of course.


in reply to: ↑ 2   Changed 3 years ago by alsroot

Replying to erikos:

Aleksey can you comment if you agree on my assumption that those logs are not necessary? If yes I will do a patch of course.

Agree, these messages are pretty annoying. If there is need to have it in released sugar, we can add special debug flag.

Changed 3 years ago by erikos

Patch against master

  Changed 3 years ago by erikos

  • keywords r? added; r! removed

  Changed 3 years ago by alsroot

  • keywords r+ added; r? removed

  Changed 3 years ago by erikos

  • status changed from new to closed
  • resolution set to fixed

Pushed as:  http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/a75cc77e2276674b4ed623695cd6d7aa823c0d37

Note: See TracTickets for help on using tickets.