Journal does not provide any error message on write errors

[bernie]

If you try to copy a file to a device which is write protected, you get no error messages, but of course the write fails.

You probably don't get errors also in other cases, such as disk full,

I/O error, etc.

Tested with sugar-datastore 0.84.1 and sugar 0.84.11.

[aa]

I just closed #1416 as a dup of this bug.

The following test cases are from that bug (by alsroot), and may be useful to those working on this one:

|TestCase|
* drag any not file-less object from Journal to RO mounted volume
* shells logs errors(but suppressing these errors means nothing for user) and keeps silent
|TestCase|
* drag any file-less object from Journal to RW mounted volume
* shells logs errors(but suppressing these errors means nothing for user) and keeps silent

[bernie]

Patch here:  http://patchwork.sugarlabs.org/patch/132/

[alsroot]

Patch uses NotifyRedAlert but it is not part of sugar-toolkit i.e. code won't work, what about just NotifyAlert and switch to red one later?

Also, patch uses _('Alert') for alert title, could be not so informative :), what about just "Disk storage error"?

volumestoolbar.py emits volume-error signal with error text taken from exception, not sure if it is a good idea to pass it directly to user visible message?

any ideas?

[alsroot]

r+ to  http://people.sugarlabs.org/anish/0001-Journal-show-error-message-on-write-failure-1842.patch

[erikos]

This has not been pushed yet, dependent on #2140.

[erikos]

I think the idea is to land this in 0.84, too (Bernie, a request from the field I suppose?). The master patch does depend on new API in sugar-toolkit, the 0.84 should just create the Alert inside the patch.

[alsroot]

trunk commit:
 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/dbdb97935d71912edff602a2b0d8bcd84d0f3992

[erikos]

I opened a downstream ticket for the 0.84 back port:  http://dev.laptop.org/ticket/10312

[erikos]

There are two little isues with this patch:

a) The string for the permision etc error is not really helpful to the user: sself.emit('volume-error', _('Input/Output error'), _('Error')) even "Error while copying" as the log string suggests would be better - other suggestions welcome :)

b) We only handle the case when we drag a file to a device. In the detail view you can copy files as well to devices: journaltoolbox.py

def _copy_menu_item_activate_cb(self, menu_item, mount):
        model.copy(self._metadata, mount.get_root().get_path())

I will have a look at how complicated it is to handle that case, too.

[erikos]

Patch against 0.84: add functionality to detail view, better error message

[erikos]

Journal: Error alert when copying to devices in the detail view, Includes better error messages.

[erikos]

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/46f194c0e9d8a053d41869e18d3d237423c6832c

As discussed with Tomeu.

[m_anish]

Thanks for improving this fix.