Ticket #1814 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Use only one entry point for activity launch

Reported by: alsroot Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: 0.90
Component: sugar Version: Git as of bugdate
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

For now, code that launch/resume activities is scattered. Having only one entry point makes launching related code more robust.

Attachments

sugar-1814.patch Download (11.5 KB) - added by alsroot 3 years ago.
0001-Do-not-allow-empty-string-activity_id-1814.patch Download (0.9 KB) - added by alsroot 3 years ago.

Change History

follow-up: ↓ 2   Changed 3 years ago by alsroot

  • keywords r? added

Patch contains also #1719 fix because it heavily depends of this ticket fix.

Changed 3 years ago by alsroot

in reply to: ↑ 1   Changed 3 years ago by alsroot

Replying to alsroot:

Patch contains also #1719 fix because it heavily depends of this ticket fix.

looks like #1719 fix could be less invasive, so this ticket patch does not contain #1719 fix

  Changed 3 years ago by tomeu

  • keywords r+ added; r? removed

This patch is great, please push if you have already tested each code path that has been made to use misc.launch().

  Changed 3 years ago by alsroot

  • status changed from new to closed
  • resolution set to fixed

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/ad88527353efdb351caef4999c17fdf1f1766662

Rechecked all use cases with recent sugar commits.

  Changed 3 years ago by alsroot

  • keywords r? added; r+ removed
  • status changed from closed to reopened
  • resolution fixed deleted

Changed 3 years ago by alsroot

follow-up: ↓ 7   Changed 3 years ago by alsroot

Regression that was introduced by implementation patch.

in reply to: ↑ 6   Changed 3 years ago by alsroot

Replying to alsroot:

Regression that was introduced by implementation patch.

At least in one case activity_id could be , from misc.resume().

  Changed 3 years ago by tomeu

  • keywords r+ added; r? removed

r+, but change the patch to test for both is None and empty string.

follow-up: ↓ 10   Changed 3 years ago by alsroot

  • status changed from reopened to closed
  • resolution set to fixed

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/2c429471b3c4384ec2f3fe23513f6964e8f39a72

in reply to: ↑ 9   Changed 3 years ago by alsroot

Replying to alsroot:

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/2c429471b3c4384ec2f3fe23513f6964e8f39a72

|TestCase|
* resume image from usb in Imageviewer activity
* there are two new buttons in activities tray

Note: See TracTickets for help on using tickets.