Ticket #1749 (closed defect: obsolete)

Opened 3 years ago

Last modified 3 years ago

mark legacy clients as valid

Reported by: sascha_silbe Owned by: sascha_silbe
Priority: Unspecified by Maintainer Milestone: Unspecified by Release Team
Component: sugar-presence-service Version: Git as of bugdate
Severity: Major Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

From src/buddy.py:

            # Validity starts off False, and becomes True when the buddy
            # either has, or has tried and failed to get, a color, a nick
            # and a key.

Currently the "has tried and failed to get" part isn't true because get_properties() doesn't tell Buddy about the failed attempt. The attached patch fixes that.
Impact: Legacy (i.e. non-Sugar) clients that are in the users Jabber roster (either via shared roster or added manually outside of Sugar) and are online will be shown in the Neighborhood (and in the groups view once added as friend). Currently they are shown in the owners color, but that's a separate bug.

Attachments

1749.patch Download (2.0 KB) - added by sascha_silbe 3 years ago.
mark legacy clients as valid

Change History

Changed 3 years ago by sascha_silbe

mark legacy clients as valid

in reply to: ↑ description   Changed 3 years ago by sascha_silbe

Replying to sascha_silbe:

Currently they are shown in the owners color, but that's a separate bug.

This is tracked as #1750 now.

  Changed 3 years ago by sascha_silbe

  • keywords r? removed
  • status changed from new to closed
  • resolution set to obsolete

The whole presence stuff will be rewritten from scratch for 0.90, so no use for these patches anymore.

Note: See TracTickets for help on using tickets.