Ticket #1736 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Disconnect icon in wifi palette

Reported by: erikos Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: 0.90
Component: sugar Version: Unspecified
Severity: Minor Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

This adds consistency to the palettes in the Neighborhood view. Patch attached.

For me it would be ok to slip it in 0.88, as it is such a minimal non-invasive change. Though, up to you Tomeu.

Attachments

Disconnect_icon_in_wifi_palette.patch Download (1.1 KB) - added by erikos 3 years ago.
Patch for the Wireless device icon palette

Change History

Changed 3 years ago by erikos

Patch for the Wireless device icon palette

follow-up: ↓ 3   Changed 3 years ago by erikos

Actually, the icon does not need to be assigned to a private member.

  Changed 3 years ago by erikos

  • milestone set to 0.90

in reply to: ↑ 1   Changed 3 years ago by tomeu

  • keywords r+ added; r? removed

Replying to erikos:

Actually, the icon does not need to be assigned to a private member.

Yup, better have it as a local variable.

  Changed 3 years ago by erikos

  • status changed from new to closed
  • resolution set to fixed

Thanks for the review!

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/55f08d78c2a12a9a18e1e245fd0f0df8f76442b5

Note: See TracTickets for help on using tickets.