Ticket #1651 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

simplify jarabe.journal.model._Cache

Reported by: sascha_silbe Owned by: sascha_silbe
Priority: Unspecified by Maintainer Milestone: Unspecified by Release Team
Component: journal Version: Git as of bugdate
Severity: Unspecified Keywords: r+
Cc: tomeu, alsroot Distribution/OS: Unspecified
Bug Status: Assigned

Description

jarabe.journal.model._Cache can be simplified a great deal just by changing the way removes are done. This decreases memory usage (as we don't need to keep a dictionary that just duplicates the list) and also fixes a bug I encountered in my version support branch (but couldn't trigger on mainline).

I've kept the class to minimize the code changes, but I cannot see a reason why we'd need it - a simple list should do.

Attachments

1651.patch Download (3.0 KB) - added by sascha_silbe 3 years ago.
simplify jarabe.journal.model._Cache

Change History

Changed 3 years ago by sascha_silbe

simplify jarabe.journal.model._Cache

  Changed 3 years ago by tomeu

  • cc alsroot added
  • component changed from sugar to journal

Aleksey is the Journal maintainer.

follow-up: ↓ 3   Changed 3 years ago by alsroot

  • keywords r+ added; r? removed

in reply to: ↑ 2   Changed 3 years ago by sascha_silbe

  • status changed from new to closed
  • resolution set to fixed

Pushed as  ab68ecfbcd67, thanks!

Note: See TracTickets for help on using tickets.