Ticket #1608 (new defect)

Opened 3 years ago

Last modified 3 years ago

no wireless disconnect functionality

Reported by: dsd Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: 0.90
Component: sugar Version: Git as of bugdate
Severity: Major Keywords: r!
Cc: sascha_silbe Distribution/OS: Unspecified
Bug Status: New

Description (last modified by sascha_silbe) (diff)

Originally reported at  http://dev.laptop.org/ticket/9788

The menu items for disconnecting from a wireless network are just stubs. It would be useful to have a real, working disconnect option.

Attachments

1608.patch Download (6.5 KB) - added by sascha_silbe 3 years ago.
fix network disconnect and discard buttons (quozl)

Change History

Changed 3 years ago by sascha_silbe

  • cc sascha_silbe added
  • status_field changed from Unconfirmed to New
  • description modified (diff)
  • version changed from Unspecified to Git as of bugdate
  • severity changed from Unspecified to Major

No wonder I was having trouble with that, and I always thought its NetworkManagers fault...
Setting severity to Major as it causes considerable confusion.

Changed 3 years ago by sascha_silbe

  • milestone changed from Unspecified by Release Team to 0.88

Changed 3 years ago by sascha_silbe

fix network disconnect and discard buttons (quozl)

Changed 3 years ago by sascha_silbe

  • keywords r? added

I've rebased the patch provided by quozl (thanks!) in  OLPC#9788 on top of current git master and tested it on XO-1. Works fine so far, but I don't quite grok what jarabe.model.network.NMSettingsConnection.set_connected() is supposed to do, so please review that part extra carefully.

Changed 3 years ago by quozl

jarabe.model.network.NMSettingsConnection.set_connected() sets the autoconnect value, which is fetched by NetworkManager, so that next time Sugar starts, NetworkManager will not require user interaction in order to begin connecting to a network.

Changed 3 years ago by tomeu

  • keywords r! added; r? removed

Looks like James has a patch that supersedes this, so I'm taking it out the review queue assuming this one doesn't need a review any more.

Changed 3 years ago by bernie

Quozl, where is this patch?

Changed 3 years ago by erikos

  • milestone changed from 0.88 to 0.90

This only landed in 0.84 as part of this patch:

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/fcb1cec3fedfda3115f2ca72adeef53d81d500aa

We should get this into 0.90, too.

Note: See TracTickets for help on using tickets.