Make timestamp retrieval in Journal more robust

[sayamindu]

The timestamp retrieval code in the journal expects the data to be int, however, sometimes it is not. The attached patch tries to fix that.

[sayamindu]

Proposed patch

[sascha_silbe]

try:

timestamp = float(metadatatimestamp?)

except ValueError:

timestamp = None

if timestamp is None:

return _('No date')

else:

return util.timestamp_to_elapsed_string(timestamp)

How about returning directly in the except clause? There's no other way that timestamp can get assigned None and it makes the code easier to read and understand.

[sayamindu]

Eegh - that is embarrassing :-). Reassigning ticket to alsroot since he's the Journal maintainer.

[alsroot]

sorry, I really missed this one and if it's not too late for string freeze

but w/ silbe's remark - wold be good to see logging.error in except block

[alsroot]

looks like we have similar code in other places, so lets investigate why we have not float some time and fix this issue in all palces

[sascha_silbe]

Here's another place that will break if timestamp is a float. Triggered this while importing data store entries from Sugar 0.82.1 (OLPC Build 801):

Traceback (most recent call last):
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.6/site-packages/jarabe/journal/listmodel.py", line 142, in on_get_value
    timestamp = int(metadata.get('timestamp', 0))
ValueError: invalid literal for int() with base 10: '1283202926.51'

#2208 is related (breakage on parsing the ctime property).

[sascha_silbe]

Fixed by ​923a7fc.

[dnarvaez]

Milestone 0.90 deleted