Ticket #151 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

browse displays a black square instead of preview

Reported by: tomeu Owned by: tomeu
Priority: minor Milestone: 0.84
Component: hulahop Version: Git as of bugdate
Severity: Minor Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Resolved

Description


Change History

  Changed 4 years ago by tomeu

Benzea saw that it is because mozilla disabled gtk double buffering. This was due to how they used to draw the text caret several years ago but in the meantime they have rewritten it making that hack unnecessary.

Removing this call fixes the preview, though should be causing one unnecessary copy at every redraw:

 http://mxr.mozilla.org/seamonkey/source/widget/src/gtk2/nsWindow.cpp#3265

  Changed 4 years ago by tomeu

  • owner changed from marcopg to tomeu
  • status changed from new to assigned

Submitted a patch upstream:  https://bugzilla.mozilla.org/show_bug.cgi?id=472051

  Changed 4 years ago by tomeu

Also, Benjamin's patch in  http://bugzilla.gnome.org/show_bug.cgi?id=566535 fixes this without having to modify mozilla.

  Changed 4 years ago by gregdek

  • distribution set to Unspecified
  • status_field set to Unconfimed
  • severity set to Minor
  • milestone set to 0.84

Let's set this to block 0.84. If we don't pull in upstream code in time, we can just slip it to 0.86.

  Changed 4 years ago by erikos

  • status_field changed from Unconfimed to Assigned

  Changed 4 years ago by tomeu

  • status changed from assigned to closed
  • resolution set to fixed

Ok, so the fix will appear in gtk+ 2.16 on which gnome 2.26 depends on.So we can close this because sugar 0.84 will depend on gnome 2.26.

follow-up: ↓ 8   Changed 4 years ago by walter

  • status changed from closed to reopened
  • resolution fixed deleted

The bug persists on the latest Soas running on the XO hardware.

Soas-2009-03051021.iso

in reply to: ↑ 7   Changed 4 years ago by tomeu

Replying to walter:

The bug persists on the latest Soas running on the XO hardware.

Soas-2009-03051021.iso

AFAIK, soas-1 has an older version of gtk2. We should test it on Soas-2.

  Changed 4 years ago by erikos

  • status changed from reopened to closed
  • resolution set to fixed
  • status_field changed from Assigned to Resolved

Looks good in Soas-2 (containing gtk2 - 2.15) - I guess we can close it then. Soas-1 does have 2.14.x - did not make it into that i presume.

Note: See TracTickets for help on using tickets.