toggle fullscreen keybinfdings got lost

[erikos]

We used to have 'alt+return' to toggle fullscreen mode. Did we have a discussion why we changed it to use 'esc' to escape it? Sorry if I just forgot about it.

We have to announce that change at least in the release notes.

The terminal activity has to remove the accelerator.

[garycmartin]

Replying to erikos:

We used to have 'alt+return' to toggle fullscreen mode. Did we have a discussion why we changed it to use 'esc' to escape it? Sorry if I just forgot about it.

I missed that one as well. Alt+enter should be the global system toggle in and out of fullscreen otherwise esc becomes another key stroke activity authors will have to avoid using (Terminal and I think Labyrinth would be effected if esc key events are used).

[eben]

Hmm, I disagree. Escape is used almost universally as a way to exit fullscreen mode. While I think the alt-enter shortcut that got you there should also exit the mode, I support the use of the escape shortcut solely for exiting (never, of course, entering) fullscreen mode.

[erikos]

Ok, we had the 'esc' in sugar to escape fullscreen for nearly 2 years, I just forgot about it, since I always used alt+enter. We defined it before in the macthbox keybindings.

To get it back we need to either define it in metacity or in the sugar keybindings.

[sayamindu]

I'm a bit confused here, but just wanted to mention that historically, fiddling around with Terminal shortcuts have resulted in people getting really annoyed, as most of the time, I have ended up breaking their favourite command line application :-).

[wadeb]

See also #440, #475.