Ticket #1458 (closed enhancement: fixed)

Opened 4 years ago

Last modified 2 years ago

Write - export as PDF

Reported by: iwikiwi Owned by: godiard
Priority: Unspecified by Maintainer Milestone: 0.90
Component: Write Version: Unspecified
Severity: Minor Keywords: r!
Cc: sascha_silbe Distribution/OS: Unspecified
Bug Status: Assigned

Description

So right now even though the API is enough exposed to allow Write to export a document as a pdf, it can't, as we are not making use of the capability.
As part of the demo at the iitm hackfest, we have created a small patch which corrects this.

Attachments

pdfwrite.patch Download (0.8 KB) - added by iwikiwi 4 years ago.
Patch for this enhancement.
0007-Add-the-option-to-export-to-PDF-SL-1458.patch Download (1.0 KB) - added by godiard 3 years ago.

Change History

Changed 4 years ago by iwikiwi

Patch for this enhancement.

Changed 4 years ago by sascha_silbe

  • cc sascha_silbe added; tomeu removed
  • keywords r? added; Write, enhancement removed
  • distribution changed from Fedora to Unspecified
  • status_field changed from Resolved to Assigned
  • priority changed from High to Unspecified by Maintainer

First of all, thanks for the patch, it's most welcome!

Please see  Code Review for an explanation of how to get your patch into the official sources. I've already fixed up the fields of this ticket to make it enter the review queue.
For future patches the  Code Guidelines might be good to know about as well, but for the current one everything is fine.

The patch is rather small (good!) and looks OK to me (from only looking at it, not diving into the code or trying it out). What do you mean with "fix to export to pdf"? This looks like something that should go into a commit message, not the source code.

Care to explain shortly to an "outsider" like me what exactly your patch does and why it is needed? How does exporting a PDF from Write work after applying it, in terms of user interactions (i.e. how does one use it)?

Changed 4 years ago by alsroot

  • milestone changed from Unspecified by Release Team to 0.88

added 0.88 milestone to not mess it w/ 0.86 patches

Changed 3 years ago by tomeu

  • owner changed from tomeu to uwog
  • status changed from new to assigned

Changed 3 years ago by walter

  • milestone changed from 0.88 to 0.90

Alas, this doesn't seem to have landed. But whereas Fructose is not gated by Sucrose, this could land whenever.

Changed 3 years ago by godiard

Changed 3 years ago by erikos

  • keywords r! added; r? removed

Thanks Gonzalo for following up on this one.

I wonder a bit, why it was not enabled before, was the API not there in previous versions of abiword? Or we just forgot about it? Can you dig that up?

Btw, this patch does ruin your pep8 cleanups :)

Changed 3 years ago by godiard

  • owner changed from uwog to godiard

Changed 2 years ago by RafaelOrtiz

Seeing sources this has landed on git, export to pdf is enabled.

related to:

 http://git.sugarlabs.org/write/mainline/commit/6722c9de1c10def1af7342b2096312cd22fe1da6

Changed 2 years ago by RafaelOrtiz

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.