Activities tray doesn't reflect well on switching between windows if there are non-sugar ones

[alsroot]

|TestCase|
* open two non-sugar X programs
* make them visible at the same time
* switch between them by clicking on windows(not in activity tray)
* activities tray doesn't reflect correct of this switching(it shows the same active window all time)

[alsroot]

Replying to alsroot:

|TestCase|
* open two non-sugar X programs

in Terminal

* make them visible at the same time
* switch between them by clicking on windows(not in activity tray)
* activities tray doesn't reflect correct of this switching(it shows the same active window all time)

[alsroot]

The problem is, for all windows(model.shell.Activity) that are created from Terminal we have the same activity_id, not sure maybe thats another issue, but anyway since we create button in activity tray per model.shell.Activity object, it could be more straightforward to use object itself for buttons dictionary rather then activity_id.

[alsroot]

new patch was reviewed by tomeu on #sugar
 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/8c8f8c6d3f669bd7f5e5c95b31ae1f6d6d3b494a

The same activity_id issue for all non-sugar windows was moved to #1456.

[alsroot]

Commited patch doesn't cover all situations, there could be situation then dbus shell method NotifyLaunch() will be invoked before activity window appeared, so activitiestray.activity_added_cb will use None key for created button.

[alsroot]

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/12d59e7b7e0d0fdca49baf29c1df233e14c48b31
 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/450a0af9aa9b8661425133115c03196b0133aa2d

[erikos]

This one is important, as in 0.86.1 closing activities is broken. We need testing of the bug fixes we land. To give a good example, I applied the fix from above on 9.04 Ubuntu 0.86.1 and it works fine :)

Thanks for the fix!