Do no use random color if metadata color is not valid

[alsroot]

Using random color for entries that are not valid could be confusing:

• random colors look like valid colors
• random colors have been changed on every update(for the same Journal entry for example)

So, using grey colors can signalize that entry is not valid.

[alsroot]

Related to #1408

[alsroot]

What designers say for using grey colors for broken icon-color?
we have grey colors already for disabled items

[eben]

What does it mean to have an "invalid" entry? I understand the need to have a sane fallback, of course, which merits a decision here, but shouldn't this be an edge case?

That said, we shouldn't be using gray for this purpose, in my mind, since that can potentially be confused with uninstantiated activities. We're talking about entries for ongoing activities here, and those need to be colored to signify that state. I think the only logical choice, when no other identity is known, is to use the identity of the current owner. That is, if it's in my Journal and my Journal isn't told its identity (its colors), then it should assume my colors instead.

This is likely to be the correct choice anyway in a number of cases, such as files copied to the Journal from non-Sugar sources, files downloaded by activities, etc. This application of identity should occur at the time an entry is added to the Journal, not at the time it is launched, so that all future actions (starting, sending, copying, etc.) retain that identity going forward.

[alsroot]

Replying to eben:

What does it mean to have an "invalid" entry? I understand the need to have a sane fallback, of course, which merits a decision here, but shouldn't this be an edge case?

In most cases, I think, it could be remains after broken ds, but activity could create ds entries with missed icon-color property.

That said, we shouldn't be using gray for this purpose, in my mind, since that can potentially be confused with uninstantiated activities. We're talking about entries for ongoing activities here, and those need to be colored to signify that state. I think the only logical choice, when no other identity is known, is to use the identity of the current owner. That is, if it's in my Journal and my Journal isn't told its identity (its colors), then it should assume my colors instead.

This is likely to be the correct choice anyway in a number of cases, such as files copied to the Journal from non-Sugar sources, files downloaded by activities, etc. This application of identity should occur at the time an entry is added to the Journal, not at the time it is launched, so that all future actions (starting, sending, copying, etc.) retain that identity going forward.

Ok, I'll post new patch.

[alsroot]

​http://git.sugarlabs.org/projects/sugar-toolkit/repos/mainline/commits/a4a2b33dacc6fb8eb1ab77c13fabb231e3845f98