Ticket #1388 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Invisible downlading progress bar in Journal

Reported by: alsroot Owned by: tomeu
Priority: Urgent Milestone: 0.86
Component: journal Version: Unspecified
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Regression in Journal, ds objects is been updated well but Journal doesn't show progress.

|TestCase|
* download any big file from Browse
* Browse's log reports about updates but there is no progress bar in Journal

Attachments

sugar-1388.patch Download (1.8 KB) - added by alsroot 4 years ago.

Change History

Changed 4 years ago by alsroot

  • keywords r? added
  • owner changed from alsroot to tomeu
  • status changed from new to assigned

Changed 4 years ago by alsroot

Progress render uses non-sugar theme, so created #1395.

Changed 4 years ago by alsroot

Changed 4 years ago by tomeu

  • keywords r+ added; r? removed

Patch looks good but I strongly recommend that instead of passing a lambda function to the signal handler, two signal handlers are used instead. There's no pin in saving a few lines of code at the cost of making the code much harder to read.

Changed 4 years ago by alsroot

  • status changed from assigned to closed
  • resolution set to fixed

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/d8e21d039b1e99f47fb107be1ce595e57dac07bf

Note: See TracTickets for help on using tickets.