Ticket #1361 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Cancel updating process in Update control panel component

Reported by: alsroot Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: 0.86
Component: sugar Version: 0.85.x
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description


Attachments

sugar-1361.patch Download (11.0 KB) - added by alsroot 4 years ago.
sugar-1361.2.patch Download (9.3 KB) - added by alsroot 4 years ago.
sugar-1361.3.patch Download (15.7 KB) - added by alsroot 4 years ago.
0001-Implement-functionality-of-the-cancel-button-1361.patch Download (8.6 KB) - added by tomeu 4 years ago.

Change History

Changed 4 years ago by alsroot

follow-up: ↓ 2   Changed 4 years ago by erikos

  • keywords r! added; r? removed

The "# ASLO knows only about stable SP releases" code is not really part of adding a cancel option, right? Would be better to put in a separate patch.

Can you state the impact on why the cancel button is more of a bug fix than a feature? Maybe a test case would emphasize it.

in reply to: ↑ 1   Changed 4 years ago by alsroot

Replying to erikos:

The "# ASLO knows only about stable SP releases" code is not really part of adding a cancel option, right? Would be better to put in a separate patch.

yup better to push it from different commit, #1369

Can you state the impact on why the cancel button is more of a bug fix than a feature? Maybe a test case would emphasize it.

Having 50 activities could be pretty painful to wait for fetching metadata and moreover for downloading upgrades for them.

Changed 4 years ago by alsroot

  Changed 4 years ago by alsroot

  • keywords r? added; r! removed

  Changed 4 years ago by alsroot

  • keywords r? removed

Changed 4 years ago by alsroot

  Changed 4 years ago by alsroot

  • keywords r? added

Changed 4 years ago by tomeu

  Changed 4 years ago by tomeu

As discussed in #sugar, for 0.86 might be better to implement a more limited cancel functionality for stability reasons.

  Changed 4 years ago by tomeu

  • keywords r+ added; r? removed
  • status changed from new to closed
  • resolution set to fixed

r+'ed by Aleksey on #sugar:

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/3546b5b1

Note: See TracTickets for help on using tickets.