Ticket #1313 (closed defect: fixed)
Activity entry icons in Journal should not be pre-lighting on rollover (fill/stroke colour reverses)
|Reported by:||garycmartin||Owned by:||tomeu|
|Priority:||Unspecified by Maintainer||Milestone:||0.86|
|Component:||sugar||Version:||Git as of bugdate|
When mousing over activity icons in the Journal, their fill and stroke colours are being reversed as part of a pre-light icon behaviour. This breaks the Sugar ownership colour metaphor for activity entries. Previous Sugar releases has no such pre-light roll over behaviour in the Journal so I'd class this as a regression.
The Journal is currently the only place I can see the rollover icon pre-lite actually happening. Aleksey pointed me to line 1091 where the stroke and fill colours are being reversed for the prelit effect:
if self._xo_color is not None: stroke_color = self._xo_color.get_stroke_color() fill_color = self._xo_color.get_fill_color() prelit_fill_color = stroke_color prelit_stroke_color = fill_color else: stroke_color = self._stroke_color fill_color = self._fill_color prelit_fill_color = self._prelit_fill_color prelit_stroke_color = self._prelit_stroke_color
Attached is a small patch to fix the issue.