Can't find unfullscreen button

[erikos]

After I hit fullscreen, I can not get back to find the fullscreen button. Sayamindu, does it have something to do with #1102?

[sayamindu]

I am a bit confused by this - some activities work, while the others do not. I vote that this be set a blocker.

[sayamindu]

Here's what I found:

The reason why the pointer motion is not being detected in case of Terminal is that the motion-notify handler in VTE (the terminal widget) returns TRUE, effectively stopping any other handler for motion-notify being invoked. I guess there is some similar issue in Mozilla as well.
This is buggy behaviour - see  this mail from Owen Taylor, where he mentions:

- MOTION_NOTIFY, PROXIMITY_IN, PROXIMITY_OUT

  These indicate state changes rather than action. A signal handler
  for one of these that returns TRUE is likely a bug. 

To confirm, I recompiled VTE with the handler returning FALSE, and with that, the unfullscreen button returned like a charm.

In such a scenario, we either have to

• Revert the change, and rely on activities themselves to provide a unfullscreen button when they want the current functionality
• Figure out some other way to do this

[sayamindu]

Found the relevant code in Xulrunner as well:  http://mxr.mozilla.org/firefox/source/widget/src/gtk2/nsWindow.cpp#4653

[erikos]

Sayamindu, thanks very much for digging this up. Ideally, we would fix it upstream, if we want to go down the road of using motion_notify.

I just checked what other apps do in full screen mode. In Firefox you have to go to the top of the screen in order to to get a toolbar back - similar to our frame behavior. Doing the same would clash with the frame, so maybe not the best option.
In the gnome terminal, a little toolbar stays open where one can go back to 'normal' mode. This would mean not floating button - though we would loose a little part of the screen.

When showing the button on mouse move, we assume that the user uses the page up and down buttons to scroll - for example in the browser. Not sure this will always be the case.

Tricky :/

[tomeu]

Replying to erikos:

Sayamindu, thanks very much for digging this up. Ideally, we would fix it upstream, if we want to go down the road of using motion_notify.

Let's fix upstreams and lobby distros to apply the patch as soon as it gets committed?

[tomeu]

In the meantime, we can release note it and comment on the workaround (using the accelerator).

[erikos]

Filed bug for mozilla:  https://bugzilla.mozilla.org/show_bug.cgi?id=517185

[sayamindu]

Bug against VTE filed:  https://bugzilla.gnome.org/show_bug.cgi?id=595445

[alsroot]

Not sure we should leave it as is, if 3 of fructose activities have issue with unfullscreen button. We can dirty fix it for now.

[alsroot]

Terminal #1402

[alsroot]

For fructose, only Browse still has this issue, we can't fix it like in #1402, maybe xulrunner has API(non-gtk) for mouse movements?

[erikos]

There is movement (review+) in the upstream bug. So it looks good that this is fixed soon.

[erikos]

Let's add it to the release notes and hope the upstream fix gets included soon.

[manuq]

This is not the case in current Sugar/Browse. Closing this as obsolete.