Ticket #1296 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

close collaboration tube after the activity window is destroyed

Reported by: tomeu Owned by: tomeu
Priority: Urgent Milestone: 0.86
Component: sugar-toolkit Version: Unspecified
Severity: Critical Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

So activities can do collaboration cleanup when the activity window is closed.

Attachments

Change History

  Changed 4 years ago by tomeu

This is needed so Write can migrate the session from the initiator to other participant. Please comment and tell if you see any negative consequence from this.

May be worth backporting to 0.84.

follow-up: ↓ 3   Changed 4 years ago by mstone

If Write is involuntarily killed, e.g. due to segfault or OOM, then this code will never be called, yes? If that happens, will the Telepathy CM still be an incorrect state as it apparently is now? (Or have I completely misunderstood the purpose of this patch?)

in reply to: ↑ 2   Changed 4 years ago by uwog

Replying to mstone:

If Write is involuntarily killed, e.g. due to segfault or OOM, then this code will never be called, yes? If that happens, will the Telepathy CM still be an incorrect state as it apparently is now? (Or have I completely misunderstood the purpose of this patch?)

Yes, it will be just like it is now. We will make AbiCollab work with improper shutdown somewhere in the future, but for now this is a good improvement to have.

  Changed 4 years ago by tomeu

  • priority changed from Unspecified by Maintainer to Urgent
  • severity changed from Unspecified to Critical
  • milestone changed from Unspecified by Release Team to 0.86

  Changed 4 years ago by tomeu

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.